Pranav, thanks, done.
Olga On Tue, Jun 26, 2012 at 11:35 AM, Pranav Saxena <pranav.sax...@citrix.com>wrote: > Hi Olga,**** > > ** ** > > You could upload your updated patch on the review board tool ( > https://reviews.apache.org) , which you have been doing earlier also . > Brian/Jessica would carry it forward from there. **** > > ** ** > > Thanks & Regards,**** > > Pranav**** > > ** ** > > *From:* Olga Smola [mailto:olya.sm...@gmail.com] > *Sent:* Tuesday, June 26, 2012 1:59 PM > *To:* Pranav Saxena; Brian Federle; Jessica Wang > *Subject:* Fwd: UI tickets: Review request**** > > ** ** > > ** ** > > ---------- Forwarded message ---------- > From: *Olga Smola* <olya.sm...@gmail.com> > Date: Tue, Jun 26, 2012 at 11:27 AM > Subject: Re: UI tickets: Review request > To: Pranav Saxena <pranav.sax...@citrix.com> > > > Pranav, > > you are right, I'll remove "async: false" from the list operation right > now and update patch from the ticket. > > Thanks, > Olga**** > > ** ** > > On Tue, Jun 26, 2012 at 11:13 AM, Pranav Saxena <pranav.sax...@citrix.com> > wrote:**** > > Hi olga, **** > > **** > > I got the point you are trying to make. I thought that the > “listOSCategories” command did not exist before and we just had > “listOsTypes “ command to work with. **** > > **** > > $.ajax({**** > > url: createURL("*listOsTypes*"),**** > > dataType: "json"**** > > **** > > $.ajax({ **** > > url: createURL("*listOsCategories*") – This has been created by > you.**** > > **** > > This looks perfectly ok . I apologize for the inconvenience caused.**** > > **** > > Question - Any reasons for setting the “*async*” variable to “False” > under the OStype ID category because as far as I know we keep “async” to > true for all the list operations ? Please correct me in case I am missing > out on something here.**** > > /***** > > $.ajax({**** > > url: > createURL(apiCmd),**** > > dataType: "json",**** > > *async: false,* > //true**** > > success: > function(json**** > > **** > > **** > > */**** > > @Brian – I have tested this functionality on my set up and it’s working > fine .You might want to review it once as well before you could merge it > with the apache branch.**** > > **** > > Regards,**** > > Pranav**** > > **** > > *From:* Olga Smola [mailto:olya.sm...@gmail.com] > *Sent:* Tuesday, June 26, 2012 1:05 PM > *To:* Brian Federle > *Cc:* Pranav Saxena; cloudstack-dev@incubator.apache.org; Jessica Wang > *Subject:* Re: UI tickets: Review request**** > > **** > > Hi Pranav, > > Excuse me, I can't understand what you mean from here "...however since > the backend API command hasn't been implemented for listing the specific OS > types". Could you please clarify which API should be implemented? Because > I've used already exists API commands "listOsCategories" and "listOsTypes". > For "listOsTypes" I use param "oscategoryid" to get only OsTypes from > specific Category. > > Best regards, > Olga**** > > On Mon, Jun 25, 2012 at 11:37 PM, Brian Federle <brian.fede...@citrix.com> > wrote:**** > > That is a good idea too, I agree. > > Also keep in mind that it will require a fair bit of UI testing too, since > this would affect numerous dialog boxes and forms throughout the UI. > > -Brian**** > > > On 6/25/12 1:04 PM, "Pranav Saxena" <pranav.sax...@citrix.com> wrote: > > >Hi Olga , > > > >I reviewed your code for the following bug which you raised - > >http://bugs.cloudstack.org/browse/CS-15292 . This looks like a more > >modular improvement in displaying the OS types as split categories. Your > >patch looks good however since the backend API command hasn't been > >implemented for listing the specific OS types , you'll have to probably > >wait a bit for this patch of yours to be merged ( Where you have written > >"api command" explicitly in your patch ). > > > >The idea definitely looks good to me. > > > >@Brian/Jessica - what are your suggestions for the same ? > > > >Regards, > >Pranav > > > > > >-----Original Message----- > >From: Olga Smola [mailto:olya.sm...@gmail.com] > >Sent: Wednesday, June 20, 2012 8:56 PM > >To: cloudstack-dev@incubator.apache.org > >Subject: UI tickets: Review request > > > >Hi, > > > >Could you please review my patches for the following tickets: > > > >http://bugs.cloudstack.org/browse/CS-15026 > >http://bugs.cloudstack.org/browse/CS-15292 > >http://bugs.cloudstack.org/browse/CS-14110 > >http://bugs.cloudstack.org/browse/CS-15290 > >http://bugs.cloudstack.org/browse/CS-15286 > >http://bugs.cloudstack.org/browse/CS-14047 > >http://bugs.cloudstack.org/browse/CS-15287 - Please take a look at the > >ticket last comment > >http://bugs.cloudstack.org/browse/CS-15315 > >http://bugs.cloudstack.org/browse/CS-4460 - Please take a look at the > >latest ticket comment. There is a problem, already discussed with Jessica > >Wang, but not completed, still need feedback, maybe some ideas how to > >correct. If you have ideas, write to me and I'll forward already > >discussed with Jessica. > > > >Thanks, > >Olga**** > > **** > > ** ** > > ** ** >
