Heya,
I was browsing through the clouddev commit and noticed that the xen.check.hvm
parameter is no hardcoded to false:
@@
-457,8<https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=blob;f=plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java;h=8a6c60546d024c3bb9f4cef9a09b336f07d3ab76;hb=8a6c60546d024c3bb9f4cef9a09b336f07d3ab76#l457>
+480,7<https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=blob;f=plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java;h=4fd202beedcfc2f2d7841c30b59891b1a9362363;hb=4fd202beedcfc2f2d7841c30b59891b1a9362363#l480>
@@ public class XcpServerDiscoverer extends DiscovererBase implements
Discoverer, L
Boolean.parseBoolean(value);
value = _params.get("xen.check.hvm");
- _checkHvm = value == null ? true : Boolean.parseBoolean(value);
-
+ _checkHvm = false;
_connPool = XenServerConnectionPool.getInstance();
_agentMgr.registerForHostEvents(this, true, false, true);
I'm not sure if this is a good idea, the 'old' default is true and that makes
it a conscious decision by the admin to allow non hvm boxes. If we want it like
this should we remove the parameter completely?
Cheers,
Hugo
