>-----Original Message----- >From: Prasanna Santhanam [mailto:prasanna.santha...@citrix.com] >Sent: Friday, July 06, 2012 4:39 PM >To: cloudstack-dev@incubator.apache.org >Subject: Re: signing off patches > >On Fri, Jul 06, 2012 at 07:01:58AM -0400, Abhinandan Prateek wrote: >> >> After reviewing patches on *review board* downloaded the patch using >> "Download Diff". The downloaded patch removes the author information. >> Is it the right way to download patch or is there some problem with >> the download functionality ? >> >> -abhi > >I see my name against the commit: >ce7bc5fb26403c5036643278532d9e04a9fd287a I sent through review-board > >Does it matter if the patch was signed-off by the author? > >-- >Prasanna.,
It will be good if we have both author and committer in the committed patch. -abhi
