> On July 6, 2012, 6:39 p.m., David Nalley wrote:
> > This is not at all the desired output.
> >
> > This is Apache CloudStack, and the about should reference "Apache
> > CloudStack"
This bug won't happen on the OSS version ('CloudStack' will always appear in
the Apache verison). The modification for this is just to be able to
conditionally change the 'About' dialog title so that 'CloudStack' isn't
hardcoded, as is the problem reported in the bug.
- Brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5811/#review8924
-----------------------------------------------------------
On July 6, 2012, 6:33 p.m., Pranav Saxena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5811/
> -----------------------------------------------------------
>
> (Updated July 6, 2012, 6:33 p.m.)
>
>
> Review request for cloudstack and Brian Federle.
>
>
> Description
> -------
>
> 1. Log in as an admin or regular user.
> 2. On the top right corner of the UI, next to the user name, click on the
> arrow that is pointed downwards.
> 3. Click on the "About" Button from the dropdown list.
>
> =================
> Expected Test Results:
> =================
>
> CloudPlatform name is expected in the message.BUT "cloudstack" is currently
> displayed.
>
> so wrote a helper function to render the text and a regular expression would
> parse the rendered text and replace 'cloudstack' with 'cloudPlatform' in case
> it is a proprietary build.
>
>
> This addresses bug CS-15425.
>
>
> Diffs
> -----
>
> ui/scripts/ui/core.js a1c58a7
>
> Diff: https://reviews.apache.org/r/5811/diff/
>
>
> Testing
> -------
>
> Verified on my local cloudstack set up.Attached the screenshot after the
> helpder function was added by me to get the desired output.
>
>
> Thanks,
>
> Pranav Saxena
>
>
