----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5766/#review8980 -----------------------------------------------------------
Ship it! Ship It! server/src/com/cloud/vm/UserVmManagerImpl.java <https://reviews.apache.org/r/5766/#comment19067> Don't want to sound overcritical but it would always be nice to add a comment if the logic seems to be unintuitive like here. Always makes life easier to maintain code :). - Nitin Mehta On July 9, 2012, 1:14 p.m., deepti dohare wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5766/ > ----------------------------------------------------------- > > (Updated July 9, 2012, 1:14 p.m.) > > > Review request for cloudstack. > > > Description > ------- > > When an instance is created with data volume, account limit for this data > volume was not checked against. Adding a check for that > > > This addresses bug CS-15429. > > > Diffs > ----- > > server/src/com/cloud/vm/UserVmManagerImpl.java b3fac70 > > Diff: https://reviews.apache.org/r/5766/diff/ > > > Testing > ------- > > Steps: > 1. create domains /ROOT/d1 + domain-admin account d1domain /ROOT/d2 + user > account d2user > 2. login admin, set all resource limits for d1domain to be 2, set all > resource limits for d2user to be 3 > 3. login d1domain, create VM 1 with no data volume: succeeded, create VM 2 > with data volume, Failed. Error message: Maximum number of resources of type > 'volume' for account name=d1domain in domain id=2 has been exceeded. > 4. login d2user, create VM 1 and VM2 both with no data volume: succeeded, > create VM 3 with data volume:failed, > Error message: "Maximum number of resources of type 'volume' for account > name=d2user in domain id=3 has been exceeded" > > > Thanks, > > deepti dohare > >
