Thank you Jason for reviewing my code. You could try launching any number of zones with whatsoever combinations possible for advanced/basic networking as mentioned earlier as well . If ever, there's an advanced networking zone found (irrespective of any number of Basic networking zones) , you'll be able to add another guest network . If there's no Advanced networking zone and any number of basic networking zones, then you won't be able to add any other network which is obviously the desired behavior for a basic networking zone set up ( default guest network for a basic zone).
Brian - you could also review my approach once. Thanks & Regards, Pranav -----Original Message----- From: Jason Bausewein [mailto:[email protected]] Sent: Tuesday, July 10, 2012 9:33 PM To: [email protected] Subject: RE: Review Request: CS-15475:Not showing "Add GuestNetwork" Tab in Network in multi zone setup(basic/advance) +1 -----Original Message----- From: Pranav Saxena [mailto:[email protected]] On Behalf Of Pranav Saxena Sent: Tuesday, July 10, 2012 3:19 AM To: Jessica Wang; Brian Federle Cc: cloudstack; Pranav Saxena Subject: Review Request: CS-15475:Not showing "Add GuestNetwork" Tab in Network in multi zone setup(basic/advance) ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5881/ ----------------------------------------------------------- Review request for cloudstack, Brian Federle and Jessica Wang. Description ------- when we configured /enabled "basic zone" on existing setup which as already configured with Advanced Zone.UI not showing the AddGuestNetwork" in the -Network page Steps: 1.Build up advance Zone setup 2.configured multiple networks and assign tags 3.navigate to Network- and click on "Add guestnetwork" button to create isolatedGuestNetwork 4.deploy a VM 5.Add another zone "Basic Zone" 6.Navigate to Network- and click on "Add guest-network" button to create isolatedGuestNetwork Actual result: "Add GuestNetwork" tab was missing when we add/configred basic zone in the existing setup(which has advance zone already) SOLUTION - Modified the logic behind displaying the "Add network tab" . Now any occurence of advanced zone set up , in any combination with a Basic zone will lead to displaying the "Add network tab" since we can have as many guest networks in an advanced zone set up. Following cases will be taken care of - 1) Only advanced zone - add network tab enabled 2) Only basic zone - Add network tab disabled 3) advanced zone with Basic zone on top - Add network tab enabled 4) Basic Zone with advanced zone on top - Add network tab enabled This addresses bug CS-15475. Diffs ----- ui/scripts/network.js 150ade2 Diff: https://reviews.apache.org/r/5881/diff/ Testing ------- Verified on my local cloudstack set up .Tested for following cases - 1)Added two zones one with Advanced networking set up and second with Basic . 2) Only advanced networking zone 3) Only basic zone Attaching the screenshot for it. Thanks, Pranav Saxena
