----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5590/#review9036 -----------------------------------------------------------
Ship it! Ship It! - Murali Reddy On July 8, 2012, 7:20 p.m., Hugo Trippaers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5590/ > ----------------------------------------------------------- > > (Updated July 8, 2012, 7:20 p.m.) > > > Review request for cloudstack. > > > Description > ------- > > Patch to add Nicira NVP support to CloudStack. As discussed this patch is > related to phase 1, which is basic L2 connectivity. L3 connectivity and > integration with the network offering for SNAT will be in phase2. > > > Diffs > ----- > > README.NiciraIntegration PRE-CREATION > api/src/com/cloud/agent/api/CreateLogicalSwitchAnswer.java PRE-CREATION > api/src/com/cloud/agent/api/CreateLogicalSwitchCommand.java PRE-CREATION > api/src/com/cloud/agent/api/CreateLogicalSwitchPortAnswer.java PRE-CREATION > api/src/com/cloud/agent/api/CreateLogicalSwitchPortCommand.java > PRE-CREATION > api/src/com/cloud/agent/api/DeleteLogicalSwitchAnswer.java PRE-CREATION > api/src/com/cloud/agent/api/DeleteLogicalSwitchCommand.java PRE-CREATION > api/src/com/cloud/agent/api/DeleteLogicalSwitchPortAnswer.java PRE-CREATION > api/src/com/cloud/agent/api/DeleteLogicalSwitchPortCommand.java > PRE-CREATION > api/src/com/cloud/agent/api/StartupNiciraNvpCommand.java PRE-CREATION > api/src/com/cloud/agent/api/to/NicTO.java b65c61e > api/src/com/cloud/agent/api/to/VirtualMachineTO.java 42d9162 > api/src/com/cloud/api/ApiConstants.java 00ec392 > api/src/com/cloud/host/Host.java 0c9d06d > api/src/com/cloud/network/Network.java 0443a0f > api/src/com/cloud/network/Networks.java 84135b8 > api/src/com/cloud/network/PhysicalNetwork.java e54fe00 > build/build-cloud-plugins.xml 61b0e62 > build/package.xml 2b5a74b > client/tomcatconf/components.xml.in f36355d > client/tomcatconf/nicira-nvp_commands.properties.in PRE-CREATION > cloud.spec 773a729 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > 496aeb3 > plugins/network-elements/nicira-nvp/.classpath PRE-CREATION > plugins/network-elements/nicira-nvp/.project PRE-CREATION > plugins/network-elements/nicira-nvp/build.xml PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/AddNiciraNvpDeviceCmd.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/DeleteNiciraNvpDeviceCmd.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/ListNiciraNvpDeviceNetworksCmd.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/ListNiciraNvpDevicesCmd.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/api/response/NiciraNvpDeviceResponse.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/NiciraNvpDeviceVO.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/NiciraNvpNicMappingVO.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/dao/NiciraNvpDao.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/dao/NiciraNvpDaoImpl.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/dao/NiciraNvpNicMappingDao.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/dao/NiciraNvpNicMappingDaoImpl.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/element/NiciraNvpElement.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/element/NiciraNvpElementService.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/guru/NiciraNvpGuestNetworkGuru.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/Attachment.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalSwitch.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalSwitchPort.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApiException.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpList.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpTag.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/TransportZoneBinding.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/VifAttachment.java > PRE-CREATION > > plugins/network-elements/nicira-nvp/src/com/cloud/network/resource/NiciraNvpResource.java > PRE-CREATION > > plugins/network-elements/ovs/src/com/cloud/network/guru/OvsGuestNetworkGuru.java > d031fee > server/src/com/cloud/host/dao/HostDaoImpl.java a6d794d > server/src/com/cloud/hypervisor/HypervisorGuruBase.java a515194 > server/src/com/cloud/network/ExternalNetworkDeviceManager.java 115de1b > server/src/com/cloud/network/NetworkManagerImpl.java de20374 > server/src/com/cloud/network/guru/ExternalGuestNetworkGuru.java daa35e3 > server/src/com/cloud/network/guru/GuestNetworkGuru.java 33cfb2d > server/src/com/cloud/server/StatsCollector.java 389b728 > setup/db/create-schema.sql afcee3f > ui/scripts/ui-custom/zoneWizard.js 3928619 > wscript_configure 0ccf40a > > Diff: https://reviews.apache.org/r/5590/diff/ > > > Testing > ------- > > Simple build check > clean-all build-all > > Testing of all api calls > * addNiciraNvpDevice > * deleteNiciraNvpDevice > * listNiciraNvpDevices > * listNiciraNvpDeviceNetwork > > Functional testing using the following procedure > * start from clean db and create zone (with guest traffic on a physical > network with stt isolation type) > * add NiciraNvp network service provider and enable > * add NiciraNcpDevice to physical network and configure using api > * create guestnetwork > * create instance linked to guest network > * check existence of logical switch and logical ports for routervm and > instance > * check connectivity between routervm and instance > * destroy host > * after shutdown of routervm and network check logical switch and ports on > nicira (should be gone) > > > Thanks, > > Hugo Trippaers > >
