> -----Original Message----- > From: Ewan Mellor [mailto:ewan.mel...@eu.citrix.com] > Sent: Monday, July 30, 2012 1:01 PM > To: cloudstack-dev@incubator.apache.org > Subject: RE: Please remember to close review board requests > > > -----Original Message----- > > From: John Kinsella [mailto:j...@stratosec.co] > > Sent: Monday, July 30, 2012 10:26 AM > > To: cloudstack-dev@incubator.apache.org > > Subject: Please remember to close review board requests > > > > Guys and gals - if you have a request in ReviewBoard that's been > marked > > "Ship It!" - it might not be obvious, but you need to go back and > close > > the request by marking it "Submitted." > > > > Please remember to do this after momentarily basking in the joy of > > having your patch accepted. :) > > > > That'll save us from having to spam the dev list with requests to > close > > out tickets, and allow us to see easier what needs to be reviewed. > > Shouldn't the committer do this? If I understand correctly, the > workflow is: > > 1. patch gets approved. > 2. committer merges patch manually. > > If number 1 happens, but then someone gets distracted before they do > number 2, then we don't want the ticket being closed as submitted. We > should have the committer do it after they push (or even better, have > some automated system do it).
I tried, but seems as a committer, you can't change the status to "Submitted" for a specific patch. > > Ewan.
