----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6275/#review9678 -----------------------------------------------------------
Ship it! Message correction looks fine! Please ship! - Vijay Venkatachalam On Aug. 1, 2012, 7:50 a.m., Deepak Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6275/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2012, 7:50 a.m.) > > > Review request for cloudstack, Murali Reddy and Pranav Saxena. > > > Description > ------- > > MS : Cent OS 6.2 64 bit , KVM host - RHEL 6.2 64 bit , Advanced Networking > Zone , Netscaler is 10 with build as 54.161 . > > Steps : > > 1. Create AutoScaleVmGroup using an API call @ > http://10.102.125.218:8096/client/api?command=createAutoScaleVmGroup&lbruleid=2&minMembers=0&maxMembers=2&vmprofileid=1&scaleuppolicyids=2&scaledownpolicyids=4 > > 2. Tried to update the maxMembers of AutoScaleVmGroup with maxMembers as -1 [ > Which is invalid no] . > > Response is : <errortext>maxmembers is an invalid value: 1</errortext> > > It is supposed to be maxmembers is an invalid value: -1 > > API Response: > > <queryasyncjobresultresponse > cloud-stack-version="3.0.5.20120729183455"><accountid>76cecebf-8b3a-4b69-9b56-30738b8794e6</accountid><userid>343af05e-f160-4613-8ee1-fd23967565d5</userid><cmd>com.cloud.api.commands.UpdateAutoScaleVmGroupCmd</cmd><jobstatus>2</jobstatus><jobprocstatus>0</jobprocstatus><jobresultcode>530</jobresultcode><jobresulttype>object</jobresulttype><jobresult><errorcode>431</errorcode><errortext>maxmembers > is an invalid value: > 1</errortext></jobresult><created>2012-07-30T15:57:37+0530</created><jobid>f05c2a0b-a388-4390-a6db-535f9abcf739</jobid></queryasyncjobresultresponse> > > > > With minMembers update it gives the proper error message : > > <errortext>minmembers is an invalid value: -1</errortext> b > > > This addresses bug CS-15745. > > > Diffs > ----- > > server/src/com/cloud/network/as/AutoScaleManagerImpl.java 758ef65 > > Diff: https://reviews.apache.org/r/6275/diff/ > > > Testing > ------- > > Verified in my setup. > > > Thanks, > > Deepak Garg > >
