> -----Original Message----- > From: Jamshid Afshar [mailto:nore...@reviews.apache.org] On Behalf Of > Jamshid Afshar > Sent: Wednesday, August 08, 2012 12:29 PM > To: cloudstack; David Nalley; Jamshid Afshar > Subject: Re: Review Request: Add initial support for Caringo's CAStor > object storage as the S3 backend. > > > > > On Aug. 8, 2012, 6:36 p.m., David Nalley wrote: > > > First, thanks for the patch. > > > I haven't looked deeply in this, but noticed the license header in > one of the files needs some work, see the below for more information: > > > http://www.apache.org/legal/src-headers.html > > > If you have questions, please don't hesitate to ask. > > > > > > --David > > Okay I removed the Copyright on the new .java but now "git format-patch > -s master" created 2 patch files. Should I try to revert the commit in > git and resubmit a single patch, or can I add these two patch files. I
Better to squash two commits into one using: http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html > tried "Update diff" but it only allows a single patch file and a > "Parent". > > > - Jamshid > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6473/#review10028 > ----------------------------------------------------------- > > > On Aug. 8, 2012, 6:24 p.m., Jamshid Afshar wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/6473/ > > ----------------------------------------------------------- > > > > (Updated Aug. 8, 2012, 6:24 p.m.) > > > > > > Review request for cloudstack. > > > > > > Description > > ------- > > > > Below is the commit message. This is my first patch, let me know if I > did anything wrong or if e.g. using "storage.root" is not how > configuring a new storage backend should be done. > > > > Add initial support for Caringo's CAStor object storage as the S3 > backend. > > > > Similar to the s3-hdfs example. Now storage.root can specify "castor" > > followed by a list of IP addresses for the nodes in the CAStor > > cluster. S3 operations will then create and read buckets and objects > > in CAStor instead of a file system. > > > > > > Diffs > > ----- > > > > awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java PRE- > CREATION > > awsapi/src/com/cloud/bridge/model/SHost.java 874b095 > > > awsapi/src/com/cloud/bridge/service/controller/s3/ServiceProvider.java > 7a36a4b > > awsapi/src/com/cloud/bridge/service/core/s3/S3Engine.java e8b73a4 > > deps/awsapi-lib/CAStorSDK.jar PRE-CREATION > > deps/awsapi-lib/jmdns-2.1.jar PRE-CREATION > > > > Diff: https://reviews.apache.org/r/6473/diff/ > > > > > > Testing > > ------- > > > > Tested a boto script I believe we got from Chiradeep > (localhost_test.py) that creates buckets and streams, does a range read > and delete. I will continue to do more testing > (http://wiki.cloudstack.org/display/QA/How+to+run+S3+Tests+against+Clou > dStack+S3+Implementation). > > > > > > Thanks, > > > > Jamshid Afshar > > > >
