> On Aug. 10, 2012, 8:58 a.m., Wido den Hollander wrote: > > It doesn't seem that complicated, but isn't this something we should > > develop in a feature branch? > > > > Currently there is also local storage support for KVM and it would be nice > > if this could be done for KVM as well. > > > > So when it gets migrated in, it works with Xen and KVM.
There is not a huge amount of change, so I created it on master. But if required it can be moved to a separate branch as well. If you look at the change, it is HV agnostic and I don't see any specific changes that needs to be done in order to support KVM or for that matter Vmware. I have tested it on Xen server. Also since this feature is part of Citrix's release of CS, Citrix QA team is verifying it on both Vmware and KVM. - Koushik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6431/#review10111 ----------------------------------------------------------- On Aug. 9, 2012, 5:45 p.m., Koushik Das wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6431/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2012, 5:45 p.m.) > > > Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. > > > Description > ------- > > Support for local data disk. Currently enable/disable config is at zone > level, in subsequent checkins it can be made more granular. > Following changes are made: > - Create disk offering API now takes an extra parameter to denote storage > type (local or shared). This is similar to storage type in service offering. > - Create/delete of data volume on local storage > - Attach/detach for local data volumes. Re-attach is allowed as long as > vm host and data volume storage pool host is same. > - Migration of VM instance is not supported if it uses local root or data > volumes. > - Migrate is not supported for local volumes. > - Zone level config to enable/disable local storage usage for service and > disk offerings. > - Local storage gets discovered when a host is added/reconnected if zone > level config is enabled. When disabled existing local storages are not > removed but any new local storage is not added. > - Deploy VM command validates service and disk offerings based on local > storage config. > - Upgrade uses the global config 'use.local.storage' to set the zone > level config for local storage. > > > Diffs > ----- > > api/src/com/cloud/api/ApiConstants.java 08b9465 > api/src/com/cloud/api/commands/CreateDiskOfferingCmd.java b3d9962 > api/src/com/cloud/api/commands/CreateZoneCmd.java b36c721 > api/src/com/cloud/api/commands/DeployVMCmd.java 9e2bc24 > api/src/com/cloud/api/commands/UpdateZoneCmd.java c22bff7 > api/src/com/cloud/api/response/DiskOfferingResponse.java 9b4f891 > api/src/com/cloud/api/response/ZoneResponse.java f591d70 > api/src/com/cloud/dc/DataCenter.java 2d3064f > client/WEB-INF/classes/resources/messages.properties 4e734e5 > server/src/com/cloud/api/ApiResponseHelper.java 399a816 > server/src/com/cloud/configuration/ConfigurationManager.java 3504204 > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4373bb3 > server/src/com/cloud/dc/DataCenterVO.java f5beda3 > server/src/com/cloud/storage/LocalStoragePoolListener.java 1be7a55 > server/src/com/cloud/storage/StorageManagerImpl.java c7dda00 > server/src/com/cloud/storage/allocator/FirstFitStoragePoolAllocator.java > 006931d > server/src/com/cloud/vm/UserVmManagerImpl.java c514a98 > setup/db/create-schema.sql b327106 > setup/db/db/schema-303to40.sql 39b5265 > ui/index.jsp 460215e > ui/scripts/configuration.js 766dcf3 > ui/scripts/storage.js e75244f > ui/scripts/system.js de0ce4d > > Diff: https://reviews.apache.org/r/6431/diff/ > > > Testing > ------- > > Tested on XS. > > > Thanks, > > Koushik Das > >
