On Fri, Aug 10, 2012 at 9:25 AM, Alex Huang <alex.hu...@citrix.com> wrote: > Chip, > > I checked in my two changes. > > 1. Removed Base64.java from test directory. > 2. Added the license back in the two classpath files.
Thanks! > I do have one concern about license in the .classpath. It's not urgent but > maybe we can address it post 4.0. These .classpath files are eclipse files > and they will get updated by others. I doubt anyone will remember to put > licenses on them. We either need to figure out a way to not checkin eclipse > files or simply just ignore missing licenses in eclipse related files. So question on that. If someone edits the project's classpath in Eclipse, does that file get re-generated? Or does it simply modify the file as-is? If it gets re-generated, then I think we should simply consider those files to be "accepted exceptions". If it modifies the file and respects comments, then I'd say we keep the license headers in there. I'm hoping to eventually figure out how to add exceptions to RAT, and then configure the report generation as a Jenkins job. If we can do that, then we'll be able to catch problems as they occur (without me doing it daily!). -chip
