Blah - I see now there are two reviews 6328 and 6427 for the same thing - 6427 has an updated diff. My apologies for not catching that. (In the future, just upload the new diff to the same review request.)
Is there a reason bookinfo.xml is deleted? --David On Mon, Aug 13, 2012 at 10:17 AM, David Nalley <da...@gnsa.us> wrote: > > >> On Aug. 13, 2012, 9:24 a.m., Prasanna Santhanam wrote: >> > Thanks Radhika and apologies for the delay. Since the VPC feature wasn't >> > merged into master at the time of your request, I was just waiting for the >> > consensus on which branch docs would go into. Now that it is merged, I see >> > no reason not to ship this. Jessica, another final approval from you? > > This still has all of the license header issues, please don't commit til > those are addressed, we want to have less compliance issues, not more. There > are a number of other issues as well, I'll work on adding comments around > that shortly. > > > - David > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6427/#review10192 > ----------------------------------------------------------- > > > On Aug. 7, 2012, 8 a.m., Radhika PC wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/6427/ >> ----------------------------------------------------------- >> >> (Updated Aug. 7, 2012, 8 a.m.) >> >> >> Review request for cloudstack and Prasanna Santhanam. >> >> >> Description >> ------- >> >> Fixed the issues mentioned by Prasanna at https://reviews.apache.org/r/6328/ >> for the Review Request #6328. >> >> >> Diffs >> ----- >> >> docs/en-US/Book_Info.xml 6ff42f2 >> docs/en-US/acquire-new-ip-for-vpc.xml PRE-CREATION >> docs/en-US/add-gateway-vpc.xml PRE-CREATION >> docs/en-US/add-loadbalancer-rule-vpc.xml PRE-CREATION >> docs/en-US/add-portforward-rule-vpc.xml PRE-CREATION >> docs/en-US/add-tier.xml PRE-CREATION >> docs/en-US/add-vm-to-tier.xml PRE-CREATION >> docs/en-US/admin-guide.xml c10455d >> docs/en-US/change-ssvm-service-offering.xml PRE-CREATION >> docs/en-US/compatibility-matrix.xml ac8e838 >> docs/en-US/configure-acl.xml PRE-CREATION >> docs/en-US/configure-vpc.xml PRE-CREATION >> docs/en-US/create-vpn-customer-gateway.xml PRE-CREATION >> docs/en-US/create-vpn-gateway-for-vpc.xml PRE-CREATION >> docs/en-US/create-vr-network-offering.xml PRE-CREATION >> docs/en-US/enable-disable-static-nat-vpc.xml PRE-CREATION >> docs/en-US/enable-disable-static-nat.xml 0895b88 >> docs/en-US/inter-vlan-routing.xml PRE-CREATION >> docs/en-US/release-ip-address.xml 59c4814 >> docs/en-US/release-ip-for-vpc.xml PRE-CREATION >> docs/en-US/release-notes-3.0.4.xml 21f47c6 >> docs/en-US/site-to-site-vpn.xml 2e29909 >> docs/en-US/upgrade-management-server.xml PRE-CREATION >> docs/en-US/using-sshkeys.xml a753b32 >> docs/en-US/vpc.xml cd298a1 >> >> Diff: https://reviews.apache.org/r/6427/diff/ >> >> >> Testing >> ------- >> >> >> Thanks, >> >> Radhika PC >> >> >
