On 08/14/2012 09:01 AM, mpat...@inforelay.com wrote:
This is totally not cool. Running this tool modifies not just agent.properties, but also just appends stuff to /etc/libvirt/{qemu.conf,libvirtd.conf} and /etc/sysconfig/libvirtd. And due to a disagreement between the changes to qemu.conf and sysconfig/libvirtd, manages to break libvirtd. Nice! At no time did the tool notify the admin as to WHAT files it was modifying and more than likely breaking, but it also didn't bother to save the originals so the changes could be undone if needed. This is BASIC etiquette!In "qemu.conf" it uses 'cgroup_controllers=["cpu"]' but in /etc/sysconfig/libvirtd it uses 'CGROUP_DAEMON='cpu:/virt' which is apparently an illegal value. Not to mention it invokes 'export' to share the variable which is a *major* no-no.
I'm working on changing the cloud-setup-agent tool and the documentation since it isn't completely necessary to use this tool to add an agent (there is a discussion regarding this on the dev list).
It's on the watch list!
This kind of nonsense might be excusable in a <1.0 release, but not this many iterations into it. Is there no QA team? I know "cloud" is new and all but come on. How can the project possibly think people should consider CS if the product if rife with bugs, ridiculous assumptions and limitations, etc? I'll GLADLY take a CLI-only toolset that works correctly over a damn web UI and wizards and other tripe that breaks in mysterious ways with no straightforward way to recover. Is OpenStack written with as much care? Guess I'll go find out.
I however would like to ask you not use such language against the developers here.
CloudStack recently moved from Citrix to the Apache foundation and a lot of developers are working on getting stuff like this fixed.
Citrix is also still putting a lot of effort into this, but not everything can be fixed at the same time.
Like I said, the cloud-setup-agent tool is on my personal radar since I also don't like what the tool is doing.
However, keep in mind that a lot of people are working very hard on this project, there is no need for saying "ridiculous assumptions" and such things.
Feedback and bugs reports are needed to improve the software, so thank you for that.
Wido
