----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6720/ -----------------------------------------------------------
Review request for cloudstack. Description ------- Latest master and 4.0 both successfully set VM password but can report false, leading to no password returned. The code tries every router/network, and if the last one tried fails it reports a failure. Since it only needs to succeed on the one router that provides userdata for that VM, I'm changing it to return success if any attempt succeeds. Diffs ----- server/src/com/cloud/vm/UserVmManagerImpl.java 6f6a754 Diff: https://reviews.apache.org/r/6720/diff/ Testing ------- Tested latest 4.0 and master as of ce54bfa7fae560470d82f6d22545398cecb5294b, UI now reports password rather than 'undefined'. Thanks, Marcus Sorensen