I was looking at the code and the way we are using checksum doesn't make sense to me. We are computing the checksum through the Java code and then passing the same checksum in the bash script post download of template to check whether the checksum matches or not. That's not the correct. I would have expected the user supplying checksum and then we verifying the checksum once the template is downloaded for any corruption.
-Nitin -----Original Message----- From: Rohit Yadav [mailto:rohit.ya...@citrix.com] Sent: Thursday, August 23, 2012 4:18 PM To: cloudstack-dev@incubator.apache.org Subject: Re: "Failed to install: x != java.lang.String" when register ISO in CS 3.0.x Hi Gavin, You're right. It got fixed before and was reverted and then was again cherry-picked. The review: https://reviews.apache.org/r/6392/ And then again got undone: https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commit;h=0307effcfa25c1ed4f4e642a0167b5376cdec140 @Edison: Please check and fix, same issue: https://reviews.apache.org/r/6392/ Regards, Rohit On 23-Aug-2012, at 3:52 PM, Gavin Lee <gavin....@gmail.com> wrote: > Dears, > I encountered the issue when register ISO, I googled and found similar > issue has beed fixed: > > http://bugs.cloudstack.org/browse/CS-15128?page=com.atlassian.jira.plu > gin.system.issuetabpanels:all-tabpanel > http://bugs.cloudstack.org/browse/CS-15156# > > But I couldn't find the fix in apache git repo or cloud.com git repo. > > I'm using apache cloudstack 3.0.x, when click the uploaded ISO, the > UI display contains following message: > Status Failed to install: x != java.lang.String > > The log vmops.log doesn't show any exception but following information: > > 2012-08-23 17:11:05,021 DEBUG [agent.transport.Request] > (AgentManager-Handler-1:null) Seq 6-213123976: Processing: { Ans: , > MgmtId: 52232246786, via: 6, Ver: v1, Flags > : 10, > [{"storage.DownloadAnswer":{"jobId":"4109c690-8f70-4908-a18d-74c841be1 > 127","downloadPct":100,"errorString":"Download > success, starting install ","downloadStatus": > "DOWNLOAD_IN_PROGRESS","downloadPath":"/mnt/SecStorage/a40491d3-9a2a-3 > a76-81c2-50919a231d25/template/tmpl/2/210/dnld3846264172469715863tmp_" > ,"installPath":"template/tmp > l//2/210","templateSize":0,"templatePhySicalSize":0,"result":false,"de > tails":"Download success, starting install ","wait":0}}] } > > 2012-08-23 17:11:15,053 DEBUG [agent.transport.Request] > (AgentManager-Handler-4:null) Seq 6-213123978: Processing: { Ans: , > MgmtId: 52232246786, via: 6, Ver: v1, Flags > : 10, > [{"storage.DownloadAnswer":{"jobId":"4109c690-8f70-4908-a18d-74c841be1 > 127","downloadPct":100,"errorString":"Failed > to install: x != java.lang.String","downloadSta > tus":"DOWNLOAD_ERROR","downloadPath":"/mnt/SecStorage/a40491d3-9a2a-3a > 76-81c2-50919a231d25/template/tmpl/2/210/dnld3846264172469715863tmp_", > "installPath":"template/tmpl > //2/210","templateSize":0,"templatePhySicalSize":0,"result":false,"det > ails":"Failed to install: x != java.lang.String","wait":0}}] } > > If it's already fixed, please tell me where I can find it; Or I can > help on this. > > Thanks. > > -- > Gavin
