----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6853/#review10887 -----------------------------------------------------------
Ship it! Thanks for the patch Gavin! I've applied to master. Please close this review as submitted. - Chip Childers On Aug. 30, 2012, 12:38 p.m., Gavin Lee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6853/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2012, 12:38 p.m.) > > > Review request for cloudstack, Devdeep Singh and Chip Childers. > > > Description > ------- > > Correct license header for files in plugin folder > > > Diffs > ----- > > > plugins/deployment-planners/user-concentrated-pod/src/com/cloud/deploy/UserConcentratedPodPlanner.java > 2b28d19 > > plugins/deployment-planners/user-dispersing/src/com/cloud/deploy/UserDispersingPlanner.java > dcad1e7 > > plugins/host-allocators/random/src/com/cloud/agent/manager/allocator/impl/RandomAllocator.java > 3ca2da1 > plugins/hypervisors/vmware/src/com/cloud/ha/VmwareFencer.java f33f1e1 > plugins/hypervisors/vmware/src/com/cloud/ha/VmwareInvestigator.java b85f307 > plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java > 4f936be > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareCleanupMaid.java > ee2f56f > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java > af53dad > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareHostService.java > 5822af8 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java > 7d85a96 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java > 91c52e5 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManager.java > b237291 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java > b525e13 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageMount.java > 9f4de50 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareContextFactory.java > f82afb8 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > c6425ee > > plugins/hypervisors/vmware/src/com/cloud/network/CiscoNexusVSMDeviceManagerImpl.java > 6963858 > > plugins/hypervisors/vmware/src/com/cloud/network/dao/CiscoNexusVSMDeviceDao.java > 95771a5 > > plugins/hypervisors/vmware/src/com/cloud/network/dao/CiscoNexusVSMDeviceDaoImpl.java > 02d9e44 > > plugins/hypervisors/vmware/src/com/cloud/storage/resource/PremiumSecondaryStorageResource.java > 2ea6768 > > plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareSecondaryStorageContextFactory.java > edbe8e6 > > plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareSecondaryStorageResourceHandler.java > bd98400 > plugins/hypervisors/xen/src/com/cloud/ha/XenServerFencer.java c9c701a > plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java f9e1c89 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java > b13730c > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java > 1cc1075 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > d87c506 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java > 8325b06 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java > d689393 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56Resource.java > 9f672c5 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56SP2Resource.java > 420d4df > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer600Resource.java > 03aa9b4 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer602Resource.java > 9c2e914 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerConnectionPool.java > 11fbd49 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerPoolVms.java > 7650d44 > > plugins/network-elements/f5/src/com/cloud/network/element/F5ExternalLoadBalancerElement.java > d685ad9 > > plugins/network-elements/f5/src/com/cloud/network/element/F5ExternalLoadBalancerElementService.java > ee288ef > > plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java > bf77192 > > plugins/network-elements/juniper-srx/src/com/cloud/api/commands/AddExternalFirewallCmd.java > df6ec16 > > plugins/network-elements/juniper-srx/src/com/cloud/api/commands/AddSrxFirewallCmd.java > 6a6bfaf > > plugins/network-elements/juniper-srx/src/com/cloud/api/commands/ConfigureSrxFirewallCmd.java > 62a5746 > > plugins/network-elements/juniper-srx/src/com/cloud/api/commands/DeleteExternalFirewallCmd.java > 1eeb27f > > plugins/network-elements/juniper-srx/src/com/cloud/api/commands/DeleteSrxFirewallCmd.java > 18ec230 > > plugins/network-elements/juniper-srx/src/com/cloud/api/commands/ListExternalFirewallsCmd.java > 48931c7 > > plugins/network-elements/juniper-srx/src/com/cloud/api/commands/ListSrxFirewallNetworksCmd.java > b8ab03b > > plugins/network-elements/juniper-srx/src/com/cloud/api/commands/ListSrxFirewallsCmd.java > 803fcc9 > > plugins/network-elements/juniper-srx/src/com/cloud/network/element/JuniperSRXExternalFirewallElement.java > ad2516b > > plugins/network-elements/juniper-srx/src/com/cloud/network/element/JuniperSRXFirewallElementService.java > f622ee7 > > plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java > 8f82785 > > plugins/network-elements/netscaler/src/com/cloud/network/NetScalerPodVO.java > 9325c14 > > plugins/network-elements/netscaler/src/com/cloud/network/dao/NetScalerPodDao.java > 4a45861 > > plugins/network-elements/netscaler/src/com/cloud/network/dao/NetScalerPodDaoImpl.java > f4df313 > > plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java > f7be3fa > > plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerLoadBalancerElementService.java > d96ced6 > > plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java > c7b31f3 > > Diff: https://reviews.apache.org/r/6853/diff/ > > > Testing > ------- > > Passed build, deploy-server and basic function testing. > > > Thanks, > > Gavin Lee > >
