----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6806/#review10996 -----------------------------------------------------------
Ship it! api/src/com/cloud/storage/GuestOsCategory.java <https://reviews.apache.org/r/6806/#comment23574> Would have loved a comment saying that None means no os preference. - Nitin Mehta On Aug. 29, 2012, 1 a.m., mice xia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6806/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2012, 1 a.m.) > > > Review request for cloudstack, Prachi Damle, Prasanna Santhanam, Jessica > Wang, and Alena Prokharchyk. > > > Description > ------- > > Fix bug CS-10284 which still exists in 4.0 > 1) add a new osCategory type 'None' for no OS preference > 2) fix UI and API side related codes > > > This addresses bug CS-10284. > > > Diffs > ----- > > api/src/com/cloud/storage/GuestOsCategory.java 96123e4 > server/src/com/cloud/resource/ResourceManagerImpl.java 98b3e5a > setup/db/db/schema-302to40.sql aaf23e6 > setup/db/templates.sql 3034c7f > ui/scripts/system.js 2a4cf5f > > Diff: https://reviews.apache.org/r/6806/diff/ > > > Testing > ------- > > tested > > > Thanks, > > mice xia > >
