----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6858/#review11006 -----------------------------------------------------------
server/src/com/cloud/user/AccountManagerImpl.java <https://reviews.apache.org/r/6858/#comment23608> Your intentions are good to give a custom log on the last erroneous login attempt. But, the message says that you are disabling the account (it should be user), which is not true. Also, you might want to throw an Exception with a message similar to the special log message and not just log & return null. Returning null will give a generic message to user - 'please provide valid credentials'. - Vijay Venkatachalam On Sept. 3, 2012, 2 p.m., saksham srivastava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6858/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2012, 2 p.m.) > > > Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Alena > Prokharchyk. > > > Description > ------- > > Added global setting login.attempts.allowed which defines the maximum > incorrect password attempts allowed. > Also after the maximum attempts are reached the user account is disabled. > > > This addresses bug CS-10219. > > > Diffs > ----- > > core/src/com/cloud/user/UserAccountVO.java 5e7c018 > server/src/com/cloud/configuration/Config.java ebcd070 > server/src/com/cloud/user/AccountManagerImpl.java 38153f3 > setup/db/create-schema.sql fa933e3 > setup/db/db/schema-302to40.sql aaf23e6 > > Diff: https://reviews.apache.org/r/6858/diff/ > > > Testing > ------- > > Verified locally. > > > Thanks, > > saksham srivastava > >
