----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6925/#review11062 -----------------------------------------------------------
Hey Hiroaki, Looks good, but i believe that was another reason why we could not include the libvirt jar as a dependency in the oss branch. Something license related, but i'll have to check the archives to check what is was. Next to that, i would like to avoid putting repositories into our poms. Ideally everything should be available from central (or from a location that we control). I known libvirt is there, but version 0.4.8 is not available yet from central. - Hugo Trippaers On Sept. 5, 2012, 10:38 a.m., Hiroaki Kawai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6925/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2012, 10:38 a.m.) > > > Review request for cloudstack. > > > Description > ------- > > Adding libvirt.org maven repository in pom.xml will automate the build, and > we can run kvm hypervisor plugin build without -Dnonoss. I also added > exec:java configuration so that we can test the hypervisor code easily. > > > Diffs > ----- > > plugins/hypervisors/kvm/pom.xml 8cdaa86 > plugins/pom.xml 2a6ca31 > > Diff: https://reviews.apache.org/r/6925/diff/ > > > Testing > ------- > > mvn && mvn test > > > Thanks, > > Hiroaki Kawai > >
