This fix is wrong, since the real reason for this regression is not we should respect only one true return, but we called both VpcVirtualRouterElement and VirtualRouterElement to handle this savePassword command, but VpcVirtualRouterElement didn't support this network, then return false.
Alena fixed it as stated in http://bugs.cloudstack.org/browse/CS-16222. Btw, there would need more work on the similar scenario. Iterate all the network elements for every commands is not a acceptable way - we suppose to only call the network element which providing the service for the network at most time, if not always. --Sheng On Fri, Aug 31, 2012 at 5:48 AM, Jayapal Reddy <[email protected]> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6871/ > ----------------------------------------------------------- > > Review request for cloudstack and Abhinandan Prateek. > > > Description > ------- > > While resetting the password on the user VM, it got failed due VPC VR > returned false. > > > This addresses bug CS-16222. > > > Diffs > ----- > > server/src/com/cloud/vm/UserVmManagerImpl.java 667b048 > > Diff: https://reviews.apache.org/r/6871/diff/ > > > Testing > ------- > > 1. Tested on basic, advanced zone. > 2. Tested on adv zone vpc VM > > > Thanks, > > Jayapal Reddy >
