----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6431/ -----------------------------------------------------------
(Updated Sept. 11, 2012, 9:50 a.m.) Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Description ------- Support for local data disk. Currently enable/disable config is at zone level, in subsequent checkins it can be made more granular. Following changes are made: - Create disk offering API now takes an extra parameter to denote storage type (local or shared). This is similar to storage type in service offering. - Create/delete of data volume on local storage - Attach/detach for local data volumes. Re-attach is allowed as long as vm host and data volume storage pool host is same. - Migration of VM instance is not supported if it uses local root or data volumes. - Migrate is not supported for local volumes. - Zone level config to enable/disable local storage usage for service and disk offerings. - Local storage gets discovered when a host is added/reconnected if zone level config is enabled. When disabled existing local storages are not removed but any new local storage is not added. - Deploy VM command validates service and disk offerings based on local storage config. - Upgrade uses the global config 'use.local.storage' to set the zone level config for local storage. Diffs ----- api/src/com/cloud/api/ApiConstants.java 425b9fb api/src/com/cloud/api/commands/CreateDiskOfferingCmd.java b3d9962 api/src/com/cloud/api/commands/CreateZoneCmd.java b36c721 api/src/com/cloud/api/commands/DeployVMCmd.java 9e2bc24 api/src/com/cloud/api/commands/UpdateZoneCmd.java c22bff7 api/src/com/cloud/api/response/DiskOfferingResponse.java 9b4f891 api/src/com/cloud/api/response/ZoneResponse.java f591d70 api/src/com/cloud/dc/DataCenter.java 2d3064f client/WEB-INF/classes/resources/messages.properties 1ec75ba server/src/com/cloud/api/ApiResponseHelper.java aee6af0 server/src/com/cloud/configuration/Config.java ebcd070 server/src/com/cloud/configuration/ConfigurationManager.java df28251 server/src/com/cloud/configuration/ConfigurationManagerImpl.java f9da08d server/src/com/cloud/dc/DataCenterVO.java a2b7d5f server/src/com/cloud/storage/LocalStoragePoolListener.java 1be7a55 server/src/com/cloud/storage/StorageManagerImpl.java 4425b71 server/src/com/cloud/storage/allocator/AbstractStoragePoolAllocator.java 87cb065 server/src/com/cloud/storage/allocator/FirstFitStoragePoolAllocator.java 006931d server/src/com/cloud/storage/allocator/LocalStoragePoolAllocator.java 991baad server/src/com/cloud/storage/allocator/StoragePoolAllocator.java 13f44e7 server/src/com/cloud/storage/allocator/UseLocalForRootAllocator.java 38e116a server/src/com/cloud/test/DatabaseConfig.java a6aa094 server/src/com/cloud/vm/UserVmManagerImpl.java cc48b2f setup/db/create-schema.sql 9e01d28 setup/db/db/schema-302to40.sql d1a5ea9 ui/scripts/configuration.js 5e76456 ui/scripts/storage.js e75244f ui/scripts/system.js 3bf43d3 Diff: https://reviews.apache.org/r/6431/diff/ Testing ------- Tested on XS. Thanks, Koushik Das