Hi, I created a patch and created a new Review Board ticket https://reviews.apache.org/r/7073/
Can anyone review this. Manikanta. On Thu, Sep 13, 2012 at 2:40 AM, Chip Childers <chip.child...@sungard.com>wrote: > On Tue, Sep 11, 2012 at 2:46 PM, Manikanta Kattamuri > <manikanta.kattam...@sungard.com> wrote: > > Yes i would like to do it in that way. > > Hey Mani, > > Please let us know if you need any help getting this into reviewboard! > > -chip > > > On Wed, Sep 12, 2012 at 12:05 AM, Chip Childers > > <chip.child...@sungard.com>wrote: > > > >> On Tue, Sep 11, 2012 at 2:33 PM, Edison Su <edison...@citrix.com> > wrote: > >> > > >> > > >> >> -----Original Message----- > >> >> From: Manikanta Kattamuri [mailto:manikanta.kattam...@sungard.com] > >> >> Sent: Tuesday, September 11, 2012 10:36 AM > >> >> To: cloudstack-dev@incubator.apache.org > >> >> Subject: Removing .classpath and .project files for the modules. > >> >> > >> >> Hi, > >> >> > >> >> There are .classpath and .project files in each module present. I > found > >> >> them to be eclipse configuration files or we using them anywhere else > >> >> (i am > >> >> not much acquainted with the codebase yet) . > >> >> Problem is these classpath files are having lib jar locations from > deps > >> >> module. As the codebase is moved to maven and the jars themselves are > >> >> removed, these files are obsolete. > >> >> > >> >> Can we remove the .classpath and .project files or we can fix the > >> >> projects > >> >> in eclipse and replace these files with new sensible ones according > to > >> >> maven practices.. > >> > > >> > > >> > +1, to remove them, as these files are managed by eclipse + maven now. > >> From http://maven.apache.org/guides/mini/guide-ide-eclipse.html, > >> > It recommends to add .classpath and .project into .gitignore. > >> > >> +1 from me as well. > >> > >> Mani - Do you want to follow the reviewboard submission process to do > >> this as your first patch for the project? > >> > >> > > >> >> > >> >> Mani. > >> > > >> > >> > >
