----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7057/#review11528 -----------------------------------------------------------
server/src/com/cloud/network/as/AutoScaleManagerImpl.java <https://reviews.apache.org/r/7057/#comment24775> Just a nitpik, please correct the spacing and the brackets. - Devdeep Singh On Sept. 12, 2012, 4:23 p.m., Vijay Venkatachalam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7057/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2012, 4:23 p.m.) > > > Review request for cloudstack, Devdeep Singh and Deepak Garg. > > > Description > ------- > > During update of Autoscale VM Group, checking if the vm group's interval is > less than duration in existing policies'. > Also, correcting typo check on disabled state of vmgroup. > > > This addresses bug CS-15781. > > > Diffs > ----- > > server/src/com/cloud/network/as/AutoScaleManagerImpl.java 8c39097 > > Diff: https://reviews.apache.org/r/7057/diff/ > > > Testing > ------- > > 1. Create Vm Group (interval 30, policies duration 60) -> Disable Vm Group -> > Update vm group with interval (interval 65). Error expected > > > Thanks, > > Vijay Venkatachalam > >
