----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7058/#review11537 -----------------------------------------------------------
Code changes look fine. Is it possible to submit two review requests for this change; one in which changes have been made and another one in which code is re-organised. The history will look cleaner. plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java <https://reviews.apache.org/r/7058/#comment24809> This function can return a boolean. - Devdeep Singh On Sept. 12, 2012, 5:05 p.m., Vijay Venkatachalam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7058/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2012, 5:05 p.m.) > > > Review request for cloudstack and Devdeep Singh. > > > Description > ------- > > AutoScale. Added clean-up if NetScaler errors out during AutoScale config. > Also re-organized NetScalerResource to keep AutoScale block together. > > > This addresses bug CS-15727. > > > Diffs > ----- > > > plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java > 0d13622 > > Diff: https://reviews.apache.org/r/7058/diff/ > > > Testing > ------- > > 1. Normal AutoScale config. > 2. Login to netscaler. Remove timer policy. > 3. Remove AutoScale VmGroup from CloudStack. > 4. NS Config should return as it was in "No 1" after the error. > > > Thanks, > > Vijay Venkatachalam > >
