----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7205/#review11772 -----------------------------------------------------------
Deepak, can you document what testing you did you do and what is expected? api/src/com/cloud/network/lb/LoadBalancingRule.java <https://reviews.apache.org/r/7205/#comment25319> Can you build the deployVm/destroyVm command's in AutoScale Manager itself? This will avoid sending these information as separate details to the resource layer. If you want you can open a separate bug and work on this later . plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java <https://reviews.apache.org/r/7205/#comment25318> Nitpick. Can you declare a separate variable for lbUuid similar to srcIP/srcPort. server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java <https://reviews.apache.org/r/7205/#comment25328> You don't seem to be using _lbDao but it is declared. - Vijay Venkatachalam On Sept. 21, 2012, 6:11 a.m., Deepak Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7205/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2012, 6:11 a.m.) > > > Review request for cloudstack, Devdeep Singh, Pranav Saxena, and Vijay > Venkatachalam. > > > Description > ------- > > Ids are used instead of UUIds for entities like template, serviceoffering. > Since NS will be making api calls on MS, so its better to use UUIDs > > > This addresses bug CS-15644. > > > Diffs > ----- > > api/src/com/cloud/agent/api/to/LoadBalancerTO.java 884c7c5 > api/src/com/cloud/network/as/AutoScaleVmGroup.java 7b882fc > api/src/com/cloud/network/lb/LoadBalancingRule.java 5c39f31 > api/src/com/cloud/network/rules/LoadBalancer.java 9c67f29 > > plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java > 57e631e > > plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java > 1b5f17a > > plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java > f2a5278 > server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java > ba3d689 > server/src/com/cloud/network/as/AutoScaleVmGroupVO.java 3de9f9b > server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 025e441 > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > 163252f > > Diff: https://reviews.apache.org/r/7205/diff/ > > > Testing > ------- > > Manual testing on my local setup. > > > Thanks, > > Deepak Garg > >
