----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7298/#review11945 -----------------------------------------------------------
Ship it! Ship It! - edison su On Sept. 26, 2012, 7:10 p.m., Marcus Sorensen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7298/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2012, 7:10 p.m.) > > > Review request for cloudstack and edison su. > > > Description > ------- > > Since /root is r-x permissions, Java fails to mkdir /root/.ssh (even though > the agent is running as root) because it looks for the writable permission. > This patch modifies the 'chmod 700 /root/.ssh' shell command that we already > use into 'mkdir -m 700 /root/.ssh', to be able to create the directory as > root even though write permissions are not set on /root. This seemed > cleaner/safer than adding writable to /root. > > > Diffs > ----- > > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java > 65742d8 > > Diff: https://reviews.apache.org/r/7298/diff/ > > > Testing > ------- > > Verified that the agent could not create /root/.ssh if I deleted it and > restarted the agent. Added this patch, and /root/.ssh was created, no problem. > > > Thanks, > > Marcus Sorensen > >
