Sorry guys. I just submitted a new review request and realized I did not used that junit-test branch, and I did not add ASF license header either. I'll do those next time.
Yichi On Mon, Sep 24, 2012 at 10:22 AM, Chip Childers <[email protected]>wrote: > Yichi, > > I just committed this, but realized that I didn't catch the fact that we > are missing the ASF license header in > api/unittest/src/com/cloud/agent/api/AttachIsoCommandTest.java. > > Can you please submit another patch to correct that? > > -chip > > > On Mon, Sep 24, 2012 at 11:21 AM, Chip Childers <[email protected] > > wrote: > >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/7204/ >> >> Ship it! >> >> Committed to the junit-tests branch. Please close this review as submitted. >> >> commit c3fafec8c0f75b0a6cfc724ac18fc1bd4364eb88 >> Author: Yichi Lu <[email protected]> >> Date: Mon Sep 24 11:19:47 2012 -0400 >> >> Adding api/unittest files >> Signed-off-by: Chip Childers <[email protected]> >> >> commit 1ea6b11d9fdfb3a2842dc05d1aadf3f8c64ca044 >> Author: Yichi Lu <[email protected]> >> Date: Mon Sep 24 11:18:07 2012 -0400 >> >> Start of unit test suite for api project >> Signed-off-by: Chip Childers <[email protected]> >> >> >> >> >> - Chip >> >> On September 21st, 2012, 3:41 a.m., Yichi Lu wrote: >> Review request for cloudstack. >> By Yichi Lu. >> >> *Updated Sept. 21, 2012, 3:41 a.m.* >> Description >> >> A junit test suite against api project. All unit tests are to be executed at >> the api/unittest directory level by running "$ mvn test". >> A directory: unittest was created under the project api. >> The unit tests are used to test java classes and their methods. They are >> intended to complement, not replace, the existing tests written in python >> marvin. >> packages used: surefire (v2.12.3), junit (v4.8.2). >> While this particular suite is junit test suite against api project, it is >> envisioned that eventually other suites be developed against other >> cloudstack projects. >> >> Testing >> >> One test class, AttachIsoCommand.java, with one test case against >> getVmName() method of api/src/com/cloud/agent/api/AttachIsoCommand class. >> >> >> USLT-205731:unittest yichi.lu$ pwd >> /Users/yichi.lu/CloudStack/incubator-cloudstack/api/unittest >> USLT-205731:unittest >> <http://yichi.lu/CloudStack/incubator-cloudstack/api/unittestUSLT-205731:unittest> >> yichi.lu$ mvn test >> [INFO] Scanning for projects... >> [INFO] >> [INFO] >> ------------------------------------------------------------------------ >> [INFO] Building Apache CloudStack API Unittest 4.0.0-SNAPSHOT >> [INFO] >> ------------------------------------------------------------------------ >> [INFO] >> [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ >> cloud-api-unittest --- >> [debug] execute contextualize >> [INFO] Using 'UTF-8' encoding to copy filtered resources. >> [INFO] skip non existing resourceDirectory >> /Users/yichi.lu/CloudStack/incubator-cloudstack/api/unittest/src/main/resources >> [INFO] >> [INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ >> cloud-api-unittest --- >> [INFO] Compiling 221 source files to >> /Users/yichi.lu/CloudStack/incubator-cloudstack/api/unittest/target/classes >> [INFO] >> [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) >> @ cloud-api-unittest --- >> [debug] execute contextualize >> [INFO] Using 'UTF-8' encoding to copy filtered resources. >> [INFO] Copying 0 resource >> [INFO] >> [INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ >> cloud-api-unittest --- >> [INFO] Compiling 1 source file to >> /Users/yichi.lu/CloudStack/incubator-cloudstack/api/unittest/src/com/cloud/agent/api >> [INFO] >> [INFO] --- maven-surefire-plugin:2.10:test (default-test) @ >> cloud-api-unittest --- >> [INFO] Surefire report directory: >> /Users/yichi.lu/CloudStack/incubator-cloudstack/api/unittest/target/surefire-reports >> >> ------------------------------------------------------- >> T E S T S >> ------------------------------------------------------- >> Running com.cloud.agent.api.AttachIsoCommandTest >> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.097 sec >> >> Results : >> >> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 >> >> [INFO] >> ------------------------------------------------------------------------ >> [INFO] BUILD SUCCESS >> [INFO] >> ------------------------------------------------------------------------ >> [INFO] Total time: 7.546s >> [INFO] Finished at: Thu Sep 20 22:31:38 CDT 2012 >> [INFO] Final Memory: 11M/554M >> [INFO] >> ------------------------------------------------------------------------ >> U >> >> Diffs >> >> - .gitignore (d772031) >> - api/pom.xml (db14775) >> - api/unittest/.gitignore (PRE-CREATION) >> - api/unittest/pom.xml (PRE-CREATION) >> - api/unittest/src/com/cloud/agent/api/.gitignore (PRE-CREATION) >> - api/unittest/src/com/cloud/agent/api/AttachIsoCommandTest.java >> (PRE-CREATION) >> - pom.xml (ef478a3) >> >> View Diff <https://reviews.apache.org/r/7204/diff/> >> > >
