-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7296/#review11981
-----------------------------------------------------------


This patch doesn't apply cleanly because of trailing white space errors. Vijay 
, could you please have a look at it once again and send an updated patch ?
This is the point where it throws the error - 

0002-CS-15927-Able-to-add-autoscale-VMs-to-static-LB-rule.patch:235: trailing 
whitespace.
  INDEX `i_autoscale_vmgroups__load_balancer_id`(`load_balancer_id`)  
: server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java:277
error: server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java: 
patch does not apply

Thanks !

- Pranav Saxena


On Sept. 26, 2012, 6:40 p.m., Vijay Venkatachalam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7296/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2012, 6:40 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Ram Ganesh.
> 
> 
> Description
> -------
> 
>  Enable AutoScale Vms to be named as "AutoScale-LB-<lbname>"
> 
> 
> This addresses bug CS-15927.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/agent/api/to/LoadBalancerTO.java 9a58d9a 
>   api/src/com/cloud/network/lb/LoadBalancingRule.java 6647b8e 
>   
> plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java
>  b78e770 
>   server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 59ae8e6 
>   setup/db/create-schema.sql bcdccab 
> 
> Diff: https://reviews.apache.org/r/7296/diff/
> 
> 
> Testing
> -------
> 
> Created AutoScale Config for LB with name "autolb"
> AutoScaledVMs got created with display name "AutoScale-LB-autolb"
> 
> 
> Thanks,
> 
> Vijay Venkatachalam
> 
>

Reply via email to