On 30/09/2012, at 2:31 AM, Noah Slater <nsla...@tumbolia.org> wrote:

> Breaking off this question:
> 
> On Sat, Sep 29, 2012 at 3:50 PM, Donal Lafferty
> <donal.laffe...@citrix.com>wrote:
> 
>> 
>> WRT emails for all GIT pulls, wouldn't broadcasting pull requests clutter
>> the dev mailing list?
> 
> 
> No, I don't think so.
> 
> A GitHub pull request is the same as someone coming to the list and asking
> us to apply a patch.
> 
> If they become a nuisance (what a wonderful problem to have!) we could
> funnel them elsewhere.
> 
> PR integration on GitHub will attract a broader base of contributions from
> the community.
> 

My understanding of the current pull request integration is that notifications 
can be sent to the list, but can not be closed or interacted with on github 
(other than requesting the original reporter to close them, or an 
administrator) - so it's not really integration as much as avoiding it slipping 
through the cracks when someone finds the github repo. Is that still the case?

Particularly with review board in place, it would seem like getting 
notifications of PRs is a good idea, but explicitly encouraging their use is 
not.

- Brett


Reply via email to