----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7251/#review12396 -----------------------------------------------------------
Ship it! After much delay (my apologies) I was able to test this locally. The threading works out fine but urllib2 fails because of its thread-unsafe nature[1]. I've ingested this patch into branch - marvin-parallel. I'm trying to replace the urllib2 with a more thread safe library[2] and will try this out once again. Issues faced can be found in the commit message. commit 67bd8ae85480bee82056567e8de2260c6186135e Author: Sebastien Goasguen <[email protected]> Date: Fri Oct 12 18:28:45 2012 +0530 Sebastien's threaded tests for marvin While this sends out workers for each test fixture there seem to be problems with urllib2 and threading. urllib2 being unsafe the threads behaviour is not deterministic. Tests timeout early or are unable to contact the CloudStack end point. Retaining the patch to test with a more thread safe library Thanks for the patch! [1] http://stackoverflow.com/questions/5825151/are-urllib2-and-httplib-thread-safe [2] http://urllib3.readthedocs.org/en/latest/index.html - Prasanna Santhanam On Sept. 25, 2012, 11:36 a.m., Sebastien Goasguen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7251/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2012, 11:36 a.m.) > > > Review request for cloudstack, Prasanna Santhanam and edison su. > > > Description > ------- > > Modified deployAndRun to pass an argument specifying a number of threads > used, also moved to argparse instead of optparse. Copied > TestCaseExecuteEngine to ThreadedTestCaseExecuteEngine and added class for > threads. Tests are put in a queue and pulled from each thread. > > > Diffs > ----- > > tools/marvin/marvin/ThreadedTestCaseExecuteEngine.py PRE-CREATION > tools/marvin/marvin/deployAndRun.py 1c82d9f > > Diff: https://reviews.apache.org/r/7251/diff/ > > > Testing > ------- > > > Thanks, > > Sebastien Goasguen > >
