----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7612/ -----------------------------------------------------------
Review request for cloudstack. Description ------- On kvm computing host, vifdriver.unplug will always fails (throws LibvirtException) and network cleanup will not be called. This was because the code first undefine the computing domain, and then tries to query the destroyed machine definition to fetch NIC information. IMHO, kvm plugin code rounds LibvirtException too much. Diffs ----- plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 1bc70fa Diff: https://reviews.apache.org/r/7612/diff/ Testing ------- Thanks, Hiroaki Kawai