> On Nov. 22, 2012, 9:39 a.m., Hugo Trippaers wrote: > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java, > > line 123 > > <https://reviews.apache.org/r/8186/diff/1/?file=222930#file222930line123> > > > > Can you release the connection here and still call the getStatusCode() > > below?
Yes, we can release the connection and still get the status code. - Hiroaki ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8186/#review13691 ----------------------------------------------------------- On Nov. 22, 2012, 8:42 a.m., Hiroaki Kawai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8186/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2012, 8:42 a.m.) > > > Review request for cloudstack. > > > Description > ------- > > Thanks to Hugo about pointing out the page > http://hc.apache.org/httpclient-3.x/threading.html , I found that we MUST > call releaseConnection when we're using HttpClient in conjunction with > MultiThreadedHttpConnectionManager. > > > Diffs > ----- > > agent/src/com/cloud/agent/AgentShell.java 774f222 > awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java 2101afe > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java > 26e7e0d > server/src/com/cloud/cluster/ClusterServiceServletImpl.java 0c3a175 > server/src/com/cloud/maint/UpgradeManagerImpl.java c1ce3f0 > > Diff: https://reviews.apache.org/r/8186/diff/ > > > Testing > ------- > > > Thanks, > > Hiroaki Kawai > >
