Sorry, typo, I meant "so no functional test cases are needed to be added here".
Thanks -min On 11/28/12 10:58 AM, "Min Chen" <min.c...@citrix.com> wrote: >Thanks Rayees. By looking into functional smoke testcase foler, we have >already had functional test cases for listVmsCmd and listRoutersCmd, so >new functional test cases are needed to be added here. I will add a simple >Junit test case using mockito to complete the patch. > >-min > >On 11/28/12 10:48 AM, "Rayees Namathponnan" ><rayees.namathpon...@citrix.com> wrote: > >> >>Hi Min, >> >>Function test cases are available at >> >>ŠŠ.. Repo/incubator-cloudstack/test/integration/smoke >> >> >>Regards, >>Rayees >> >> >>On 11/28/12 10:00 AM, "Min Chen" <min.c...@citrix.com> wrote: >> >>>Thanks for the clarification. >>> >>>-min >>> >>>On 11/27/12 7:48 PM, "Chip Childers" <chip.child...@sungard.com> wrote: >>> >>>>+1 to what everyone is saying. This sounds like a functional test is >>>>needed, along with a simple unit test for completeness. >>>> >>>>- chip >>>> >>>>Sent from my iPhone. >>>> >>>>On Nov 27, 2012, at 8:33 PM, Sudha Ponnaganti >>>><sudha.ponnaga...@citrix.com> wrote: >>>> >>>>> Min, >>>>> >>>>> Here is the link to the current framework >>>>> https://cwiki.apache.org/CLOUDSTACK/testing-with-python.html >>>>> >>>>> Also check out Rohit's CLI as well. That would also help to automate >>>>>faster >>>>> >>>>> Thanks >>>>> /Sudha >>>>> >>>>> -----Original Message----- >>>>> From: David Nalley [mailto:da...@gnsa.us] >>>>> Sent: Tuesday, November 27, 2012 5:28 PM >>>>> To: cloudstack-dev@incubator.apache.org >>>>> Subject: Re: [DISCUSS]How to write API Unit Tests >>>>> >>>>> On Tue, Nov 27, 2012 at 6:09 PM, Min Chen <min.c...@citrix.com> >>>>>wrote: >>>>>> Hi there, >>>>>> >>>>>> In working with API refactoring work, I cannot help wondering >>>>>> how we should write Junit test cases for our APIs. Recently I saw >>>>>>that >>>>>> Chip has merged some of his API unit test cases into master branch, >>>>>> and his api unit test cases are written using Mockito, so no DB and >>>>>> real MS are needed in running these Junit test cases. Here I want to >>>>>> raise this topic again to get some clarifications on api unit test >>>>>>guidelines: >>>>>> 1. Should we require API unit test cases to be able to run >>>>>> without DB existing or MS running? >>>>>> 2. If answer is yes, then I guess that we just need to use >>>>>> Mockito to write our api unit test cases. >>>>>> 3. If answer is no, there are several follow-up questions to >>>>>>be >>>>>>clarified: >>>>>> 1) Does test case itself need to handle starting MS and >>>>>>stopping MS? >>>>>> 2) How should we set up a test DB? This may be needed for >>>>>> those list APIs. >>>>>> 3) Testcases need to handle tear down test data >>>>>>afterwards. >>>>>> >>>>>> Thanks >>>>>> -min >>>>> >>>>> So unit tests (IMO) should not need external resources to run, should >>>>>be very fast, etc as Sudha has indicated. >>>>> >>>>> If you need DB access, that sounds much more like a >>>>>functional/integration test to my ears. >>>>> >>>>> --David >>>>> >>> >> >
