-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8172/#review14081
-----------------------------------------------------------
Ship it!
Please git pull latest api refactoring, the patch was big about 5-6k lines and
huge merge conflicts, took me some time to merge them.
Please check the code, in case I missed something.
The build system is broken now, we need to fix it.
Committed in api_refactoring;
commit b0ce8fd4ff512c7a7da0a71671c4477492e854e7
Author: Min Chen <min.c...@citrix.com>
Date: Wed Dec 5 16:18:38 2012 -0800
api: Optimize and improve api, db call perfomance
This is part 1 of list API refactoring. Commands covered:
listVmsCmd, listRoutersCmd Response covered:
UserVmResponse, DomainRouterResponse. DB views created:
user_vm_view, domain_router_view.
Signed-off-by: Rohit Yadav <bhais...@apache.org>
- Rohit Yadav
On Nov. 29, 2012, 6:57 p.m., Min Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8172/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2012, 6:57 p.m.)
>
>
> Review request for cloudstack and Prachi Damle.
>
>
> Description
> -------
>
> This is part 1 of list API refactoring.
> Commands covered: listVmsCmd, listRoutersCmd
> Response covered: UserVmResponse, DomainRouterResponse.
> DB views created: user_vm_view, domain_router_view.
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-527.
>
>
> Diffs
> -----
>
> api/src/com/cloud/api/ResponseGenerator.java 4e8fbd8
> api/src/com/cloud/api/ResponseObject.java 2d08fb9
> api/src/com/cloud/api/commands/ListRoutersCmd.java 8bf9ba8
> api/src/com/cloud/api/commands/ListVMsCmd.java 2f6f988
> api/src/com/cloud/api/response/BaseResponse.java e343a10
> api/src/com/cloud/api/response/ControlledViewEntityResponse.java
> PRE-CREATION
> api/src/com/cloud/api/response/DomainRouterResponse.java d710aad
> api/src/com/cloud/api/response/NicResponse.java 69d5c31
> api/src/com/cloud/api/response/UserVmResponse.java f74c072
> api/src/com/cloud/api/view/vo/ControlledViewEntity.java PRE-CREATION
> api/src/com/cloud/api/view/vo/DomainRouterJoinVO.java PRE-CREATION
> api/src/com/cloud/api/view/vo/UserVmJoinVO.java PRE-CREATION
> api/src/com/cloud/server/ManagementService.java 7532cae
> api/src/com/cloud/vm/UserVmService.java 98d02db
> api/test/src/com/cloud/api/commands/test/ListRoutersCmdTest.java
> PRE-CREATION
> api/test/src/com/cloud/api/commands/test/ListVmsCmdTest.java PRE-CREATION
> server/src/com/cloud/api/ApiDBUtils.java 3b5f634
> server/src/com/cloud/api/ApiResponseHelper.java ebe8415
> server/src/com/cloud/api/ApiServer.java a5c9ea5
> server/src/com/cloud/api/response/ApiResponseSerializer.java 4be5dfa
> server/src/com/cloud/configuration/DefaultComponentLibrary.java ef61044
> server/src/com/cloud/server/ManagementServerImpl.java 117be57
> server/src/com/cloud/user/AccountManager.java 90a34ad
> server/src/com/cloud/user/AccountManagerImpl.java f595478
> server/src/com/cloud/vm/UserVmManager.java 4ce9bfe
> server/src/com/cloud/vm/UserVmManagerImpl.java 687f521
> server/src/com/cloud/vm/dao/DomainRouterJoinDao.java PRE-CREATION
> server/src/com/cloud/vm/dao/DomainRouterJoinDaoImpl.java PRE-CREATION
> server/src/com/cloud/vm/dao/UserVmJoinDao.java PRE-CREATION
> server/src/com/cloud/vm/dao/UserVmJoinDaoImpl.java PRE-CREATION
> server/test/com/cloud/keystore/KeystoreTest.java e0e2126
> server/test/com/cloud/user/MockAccountManagerImpl.java 08234fd
> server/test/com/cloud/vm/MockUserVmManagerImpl.java 35ee139
> setup/db/create-schema.sql fff084e
> utils/src/com/cloud/utils/db/GenericDaoBase.java 8d5cb96
>
> Diff: https://reviews.apache.org/r/8172/diff/
>
>
> Testing
> -------
>
> Create a performance unit test class to test the performance time.
>
>
> Thanks,
>
> Min Chen
>
>
