----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8427/#review14206 -----------------------------------------------------------
Ship it! Applied on api_refactoring, pl. close the review. commit 30941c2d31a530a633796a5d7613f07365bb0fe7 Author: Min Chen <[email protected]> Date: Fri Dec 7 16:22:28 2012 -0800 api: Refactoring ListEventsCmd and EventResponse, and create Event db view. - Rohit Yadav On Dec. 8, 2012, 12:25 a.m., Min Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8427/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2012, 12:25 a.m.) > > > Review request for cloudstack and Rohit Yadav. > > > Description > ------- > > Refactoring ListEventsCmd and EventResponse, and create Event db view. > > > This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-527. > > > Diffs > ----- > > api/src/com/cloud/api/response/EventResponse.java b8b5dfd > api/src/com/cloud/api/view/vo/EventJoinVO.java PRE-CREATION > api/src/com/cloud/api/view/vo/ResourceTagJoinVO.java 070720b > api/src/com/cloud/api/view/vo/SecurityGroupJoinVO.java c679d3d > api/src/com/cloud/server/ManagementService.java 5ee9054 > api/src/org/apache/cloudstack/api/ResponseGenerator.java 4f0c804 > api/src/org/apache/cloudstack/api/user/event/command/ListEventsCmd.java > 56f1626 > server/src/com/cloud/api/ApiDBUtils.java b537bcb > server/src/com/cloud/api/ApiResponseHelper.java 7bb2f5e > server/src/com/cloud/api/ApiServer.java bacec72 > server/src/com/cloud/configuration/DefaultComponentLibrary.java 89313e9 > server/src/com/cloud/event/dao/EventJoinDao.java PRE-CREATION > server/src/com/cloud/event/dao/EventJoinDaoImpl.java PRE-CREATION > server/src/com/cloud/server/ManagementServerImpl.java fba6ac9 > server/src/com/cloud/tags/TaggedResourceManagerImpl.java 3224bc9 > server/src/com/cloud/tags/dao/ResourceTagJoinDaoImpl.java 6593f90 > setup/db/create-schema.sql 3129fd5 > > Diff: https://reviews.apache.org/r/8427/diff/ > > > Testing > ------- > > > Thanks, > > Min Chen > >
