----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8454/#review14282 -----------------------------------------------------------
Ship it! Applied in api_refactoring: commit c83323fea77ebbd87adf0f793362f4ba915a007b Author: Min Chen <[email protected]> Date: Mon Dec 10 17:39:25 2012 -0800 api: Refactoring ListUsersCmd and UserResponse. - Rohit Yadav On Dec. 11, 2012, 1:43 a.m., Min Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8454/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2012, 1:43 a.m.) > > > Review request for cloudstack and Rohit Yadav. > > > Description > ------- > > Refactor ListUsersCmd and UserResponse, and create UserAccount db view. > > > This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-527. > > > Diffs > ----- > > api/src/com/cloud/user/AccountService.java e9558fc > api/src/org/apache/cloudstack/api/ResponseGenerator.java 2ccbec5 > api/src/org/apache/cloudstack/api/command/admin/user/ListUsersCmd.java > c7f0cbb > api/src/org/apache/cloudstack/api/response/UserResponse.java 2868be4 > api/src/org/apache/cloudstack/api/view/vo/UserAccountJoinVO.java > PRE-CREATION > server/src/com/cloud/api/ApiDBUtils.java f3ee0ed > server/src/com/cloud/api/ApiResponseHelper.java 04a9314 > server/src/com/cloud/configuration/DefaultComponentLibrary.java 5dc1c80 > server/src/com/cloud/user/AccountManagerImpl.java c0cbe47 > server/src/com/cloud/user/dao/UserAccountJoinDao.java PRE-CREATION > server/src/com/cloud/user/dao/UserAccountJoinDaoImpl.java PRE-CREATION > server/test/com/cloud/user/MockAccountManagerImpl.java 90422c7 > setup/db/create-schema.sql 406145c > > Diff: https://reviews.apache.org/r/8454/diff/ > > > Testing > ------- > > > Thanks, > > Min Chen > >
