----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8537/#review14333 -----------------------------------------------------------
Ship it! Applied in api_refactoring: commit 9c93fee0dcde2927d9819cf82b86237b632f35d0 Author: Min Chen <min.c...@citrix.com> Date: Tue Dec 11 15:42:52 2012 -0800 Refactor ListProjectAccountCmd and ProjectAccountResponse. - Rohit Yadav On Dec. 11, 2012, 11:44 p.m., Min Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8537/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2012, 11:44 p.m.) > > > Review request for cloudstack and Rohit Yadav. > > > Description > ------- > > Refactor ListProjectAccountCmd and ProjectAccountResponse, and create DB view > for ProjectAccount. > > > This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-527. > > > Diffs > ----- > > api/src/com/cloud/projects/ProjectService.java 2ef367b > api/src/org/apache/cloudstack/api/ResponseGenerator.java 383ecf8 > > api/src/org/apache/cloudstack/api/command/user/account/ListProjectAccountsCmd.java > b0cdcd9 > api/src/org/apache/cloudstack/api/response/ProjectAccountResponse.java > c20c023 > api/src/org/apache/cloudstack/api/view/vo/ProjectAccountJoinVO.java > PRE-CREATION > server/src/com/cloud/api/ApiDBUtils.java a60f91b > server/src/com/cloud/api/ApiResponseHelper.java 76fe58d > server/src/com/cloud/configuration/DefaultComponentLibrary.java af7a84d > server/src/com/cloud/projects/ProjectManagerImpl.java d9ff0b3 > server/src/com/cloud/projects/dao/ProjectAccountJoinDao.java PRE-CREATION > server/src/com/cloud/projects/dao/ProjectAccountJoinDaoImpl.java > PRE-CREATION > server/src/com/cloud/user/dao/UserAccountJoinDao.java 05858d0 > server/src/com/cloud/user/dao/UserAccountJoinDaoImpl.java 8ffff0f > server/test/com/cloud/projects/MockProjectManagerImpl.java dad777a > setup/db/create-schema.sql 6699d76 > > Diff: https://reviews.apache.org/r/8537/diff/ > > > Testing > ------- > > > Thanks, > > Min Chen > >