----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8180/#review14438 -----------------------------------------------------------
The patch applies cleanly, but it does not build. I stopped at two errors. There's a syntax error in en-US/creating-network-offerings.xml at line 21 - there are two comment closures (-->) so you need to remove one. It also fails at creating-network-offerings.xml:201: validity error : IDREF attribute linkend references an unknown ID "firewall-rules" You might want to pull master to be sure it's up to date, create a fresh branch and then test there to ensure that this builds with Publican. Thanks! - Joe Brockmeier On Dec. 13, 2012, 11:32 a.m., Radhika PC wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8180/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2012, 11:32 a.m.) > > > Review request for cloudstack, Chip Childers, Venkata Siva Vijayendra > Bhamidipati, Jessica Tomechak, Murali Reddy, and Joe Brockmeier. > > > Description > ------- > > This review request is for the documentation written for the following > features: > > Optional Public IP assignment for EIP with Basic Zone > User-provided host name in vCenter > > > Diffs > ----- > > docs/en-US/about-working-with-vms.xml 47153e2 > docs/en-US/append-displayname-vms.xml PRE-CREATION > docs/en-US/creating-network-offerings.xml ab56920 > docs/en-US/elastic-ip.xml PRE-CREATION > docs/en-US/networks.xml a7b9ea1 > docs/en-US/prepare-system-vm-template.xml 22674d4 > docs/en-US/set-up-network-for-users.xml 2b40923 > docs/en-US/virtual-machines.xml 7c74932 > > Diff: https://reviews.apache.org/r/8180/diff/ > > > Testing > ------- > > Patch cleanly applies. doc is reviewed by QA > > > Thanks, > > Radhika PC > >
