I had already shared the review, look at my first comment. -Koushik
> -----Original Message----- > From: Joe Brockmeier (JIRA) [mailto:j...@apache.org] > Sent: Thursday, December 20, 2012 9:57 PM > To: cloudstack-dev@incubator.apache.org > Subject: [jira] [Commented] (CLOUDSTACK-605) Host physical CPU is > incorrectly calculated for Vmware hosts > > > [ https://issues.apache.org/jira/browse/CLOUDSTACK- > 605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment- > tabpanel&focusedCommentId=13537131#comment-13537131 ] > > Joe Brockmeier commented on CLOUDSTACK-605: > ------------------------------------------- > > Koushik - can you submit the patch that was used for CS-16863? > > > Host physical CPU is incorrectly calculated for Vmware hosts > > ------------------------------------------------------------ > > > > Key: CLOUDSTACK-605 > > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-605 > > Project: CloudStack > > Issue Type: Bug > > Security Level: Public(Anyone can view this level - this is the > > default.) > > Components: VMware > > Affects Versions: pre-4.0.0, 4.0.0 > > Reporter: Koushik Das > > Assignee: Koushik Das > > Fix For: 4.0.1 > > > > > > There is a mismatch in host CPU count displayed in CS UI (displayed under > the 'Statistics' tab when a host is selected) compared to that in vCenter. The > mismatch happens for ESX hosts having > 1 cpu package. This will affect VM > allocation logic. > > Currently host CPU is computed based on below logic > > (HostHardwareSummary is defined in Vmware library) > HostHardwareSummary > > hardwareSummary = getHostHardwareSummary(); > > > summary.setCpuCount(hardwareSummary.getNumCpuCores()*hardwareSu > mmary.g > > etNumCpuPkgs()); The correct logic is to use > > hardwareSummary.getNumCpuCores() only. > > -- > This message is automatically generated by JIRA. > If you think it was sent incorrectly, please contact your JIRA administrators > For more information on JIRA, see: http://www.atlassian.com/software/jira
