> On Jan. 5, 2013, 12:29 a.m., edison su wrote: > > Or, we can use a config file, to specify the path of mkisofs. We already > > have a utils/conf/db.properties or utils/conf/db.properties.override to > > config db user and password. we can add a new file called: > > utils/conf/env.properties, which can have a entry called: > > MKISOFSPATH=mkisofs as default. If developer wants to override this > > configuration, need to create a new file called: > > utils/conf/env.properties.override, set MKISOFSPATH=genisoimage. In this > > way, there is no hard coding in the pom file. How do you think?
That would be one possibility. To me it sounds more complex, and would not have the desirable property of just working on common platforms. Of course it's your call, but I think that this is a small and well contained complexity increase in the maven files that actually bring some benefits. - Noa ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8838/#review15089 ----------------------------------------------------------- On Jan. 4, 2013, 11:51 p.m., Noa Resare wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8838/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2013, 11:51 p.m.) > > > Review request for cloudstack. > > > Description > ------- > > Due to differing licensing philosophies between the Debian project and the > mkisofs maintainer the tool will probably never be shipped as part of Debian. > > There is a tool named genisoimage that is command line parameter compatible > with mkisofs and does the same thing. > > The attached patch uses the maven profile system to parameterize the binary > used to generate iso files depending on what is available on the system. > > > This addresses bug CLOUDSTACK-792. > > > Diffs > ----- > > console-proxy/pom.xml 2526503 > > Diff: https://reviews.apache.org/r/8838/diff/ > > > Testing > ------- > > > Thanks, > > Noa Resare > >
