Please do not commit this until the questions raised about IP clearance have been resolved. Even before the corrections noted by Rohit, I can see that this is a reasonably sized submission that needs agreement before being applied.
- chip On Jan 9, 2013, at 8:52 PM, Rohit Yadav <bhais...@apache.org> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8905/#review15223 > ----------------------------------------------------------- > > > Hi Hari, this patch does not apply on master. You should not use > IdentityMapper (which is removed) and use correct API and Param annotation, > package name (in org.apache.cloudstack.api.{user,admin}....), I'll post a > wiki on how to write plugin/pluggableserver/adapter and cmd/response classes > soon, for now you can see other cmd/response classes and follow the pattern. > Rebasing your patch will save you sometime to avoid rewriting the whole set > of classes. > > May be this can be a separate plugin? > > - Rohit Yadav > > > On Jan. 9, 2013, 10:51 a.m., Harikrishna Patnala wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/8905/ >> ----------------------------------------------------------- >> >> (Updated Jan. 9, 2013, 10:51 a.m.) >> >> >> Review request for cloudstack and Abhinandan Prateek. >> >> >> Description >> ------- >> >> A user VM can be associated with a SSH key pair while deploying that VM. A >> user can SSH into the VM using the SSH private Key. >> using this feature we can reset that SSH key pair corresponding to that VM, >> i.e., to associate a new SSH key pair to the VM. >> >> >> This addresses bug CLOUDSTACK-297. >> >> >> Diffs >> ----- >> >> api/src/com/cloud/api/commands/ResetSSHKeyCmd.java PRE-CREATION >> api/src/com/cloud/event/EventTypes.java e69e4a4 >> api/src/com/cloud/network/element/UserDataServiceProvider.java 321ccc7 >> api/src/com/cloud/vm/UserVmService.java 98d02db >> client/tomcatconf/commands.properties.in 1e70c0f >> server/src/com/cloud/network/NetworkManager.java ef0d4c5 >> server/src/com/cloud/network/NetworkManagerImpl.java f7189df >> server/src/com/cloud/network/element/CloudZonesNetworkElement.java ae8be0d >> server/src/com/cloud/network/element/VirtualRouterElement.java 4ff1082 >> server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java >> 2980871 >> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java >> fcba6df >> server/src/com/cloud/vm/UserVmManagerImpl.java 9356048 >> server/test/com/cloud/network/MockNetworkManagerImpl.java 0b83f35 >> server/test/com/cloud/vm/MockUserVmManagerImpl.java 35ee139 >> server/test/com/cloud/vpc/MockNetworkManagerImpl.java 824e40d >> >> Diff: https://reviews.apache.org/r/8905/diff/ >> >> >> Testing >> ------- >> >> I did the manual testing >> - Reset SSH keys for VM already having SSH key >> - Reset SSH keys for VM created from password enabled template and already >> having SSH key >> - Reset SSH keys for VM having no SSH key >> - Reset SSH keys for VM created from password enabled template and have no >> previous SSH key >> - Reset SSH keys for VM already having SSH key when VM is in running state >> - Reset SSH keys for VM created from password enabled template and already >> having SSH key and VM is in running state >> >> >> Thanks, >> >> Harikrishna Patnala >
