----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8889/#review15232 -----------------------------------------------------------
Ship it! I added additional condition for VPC VR and committed the code. Thanks Ilia Shakitko for the fix. - Kishan Kavala On Jan. 9, 2013, 4:31 a.m., Ilia Shakitko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8889/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2013, 4:31 a.m.) > > > Review request for cloudstack, Kishan Kavala, Wei ZHOU, and Ilia Shakitko. > > > Description > ------- > > The usage server can give the system usage of each virtual machine (such as > running time, ServiceOffering, IPAddress, Volume, Template, ISO, Port > Forwarding Rule, Network offering), except the network bytes sent/received. > This problem only exists in CloudStack 4.0. In CloudStack 3.0.2, the usage > server works well. > > This is a patch for this issue (all details are described here: > https://issues.apache.org/jira/browse/CLOUDSTACK-721) > > > This addresses bug CLOUDSTACK-721. > > > Diffs > ----- > > VirtualNetworkApplianceManagerImpl.java 943c85f > > Diff: https://reviews.apache.org/r/8889/diff/ > > > Testing > ------- > > Creating VM (with new network): done > Console working (for VM with new network): done > Creating VM: done > Console working: done > Aquire new IP: done > Enabling static NAT: done > Enable firewall rules: done > Login to VM: done > Stop VM: done > Start VM: done > Reset pass: done > Destroy VM: done > Make some external (to internet) TCP traffic: done > Make some external (to internet) UDP traffic: done > Make some external (to internet) ICMP traffic: done > Make some external (to VM in different nerwork) TCP traffic: done > Make some external (to VM in different nerwork) UDP traffic: done > Make some external (to VM in different nerwork) ICMP traffic: done > Make some internal (current nerwork) TCP traffic: done > Make some internal (current nerwork) UDP traffic: done > Make some internal (current nerwork) ICMP traffic: done > > Generating, aggregating and database storing correct. Didn't check Unicast > and Broadcast traffic yet. > > > Thanks, > > Ilia Shakitko > >
