-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8908/#review15282
-----------------------------------------------------------
Ship it!
Thanks for the patch!
commit 1033200b0b5943cc21d5397d12d3b54b69aa2273
Author: Noa Resare <n...@spotify.com>
Date: Wed Jan 9 16:39:10 2013 +0100
CLOUDSTACK-933: CglibThrowableRendererTest writing stack traces...
Improve CglibThrowableRenderer test case
Log to a separate Logger instead of the default one to avoid spurious
stack traces in test run output.
Actually verify that registering CglibThrowableRenderer with the
alternative log hierarchy actually removes call trace lines that
contains the string <generated>
- Chip Childers
On Jan. 9, 2013, 3:42 p.m., Noa Resare wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8908/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2013, 3:42 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Log to a separate Logger instead of the default one to avoid spurious
> stack traces in test run output.
>
> Actually verify that registering CglibThrowableRenderer with the
> alternative log hierarchy actually removes call trace lines that
> contains the string <generated>
>
>
> This addresses bug CLOUDSTACK-933.
>
>
> Diffs
> -----
>
> utils/test/com/cloud/utils/log/CglibThrowableRendererTest.java 5a9501d
>
> Diff: https://reviews.apache.org/r/8908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Noa Resare
>
>
