----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9011/#review15462 -----------------------------------------------------------
Ship it! Ship It! - Marcus Sorensen On Jan. 17, 2013, 7:38 p.m., Brian Angus wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9011/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2013, 7:38 p.m.) > > > Review request for cloudstack and Marcus Sorensen. > > > Description > ------- > > This needs to be used to create a new feature branch. > > Feature Spec: > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Add+Remove+Networks+to+VMs > Jira Request: https://issues.apache.org/jira/browse/CLOUDSTACK-645 > > Added addNicToVirtualMachine, removeNicFromVirtualMachine, and > updateDefaultNicForVirtualMachine api commands. > > > This addresses bug CLOUDSTACK-645. > > > Diffs > ----- > > api/src/com/cloud/vm/UserVmService.java b1ebe10 > api/src/org/apache/cloudstack/api/command/user/vm/AddNicToVMCmd.java > PRE-CREATION > api/src/org/apache/cloudstack/api/command/user/vm/RemoveNicFromVMCmd.java > PRE-CREATION > > api/src/org/apache/cloudstack/api/command/user/vm/UpdateDefaultNicForVMCmd.java > PRE-CREATION > client/tomcatconf/commands.properties.in 182cbd8 > server/src/com/cloud/network/NetworkManagerImpl.java 0a1fcd7 > server/src/com/cloud/vm/UserVmManagerImpl.java a6fbdb1 > server/src/com/cloud/vm/VirtualMachineManager.java 4f04617 > server/src/com/cloud/vm/VirtualMachineManagerImpl.java 4d94fc5 > server/test/com/cloud/vm/MockUserVmManagerImpl.java 27508b1 > server/test/com/cloud/vm/MockVirtualMachineManagerImpl.java 6723198 > > Diff: https://reviews.apache.org/r/9011/diff/ > > > Testing > ------- > > This was tested and works on devcloud and devcloud-kvm. I plan to add some > automated tests as well. > > > Thanks, > > Brian Angus > >
