Thanks Hugo. I reviewed your change, most are ok, except your fix on
"vm_template iso". There is no table vm_template_iso, my previous SQL
statement is to use alias as "cloud.vm_template iso". I will fix that.
Also will do the similar formatting and prefixing tables with 'cloud' in
fresh install sql as well.

-min

On 1/22/13 2:04 AM, "Hugo Trippaers" <[email protected]> wrote:

>Hey Min,
>
>Can you have a look at this file? The schema-40to41.sql that you commited
>did not work for me
>
>* SQL comments are two dashes, not three
>* I can't find table vm_template_iso in  Apache CloudStack
>* You added 'use cloud' somewhere in the middle, please stick to the
>standard of prefixing tables with `cloud`.
>
>I fixed most of the issues I could find and currently it is possible to
>apply this sql file. Could you carefully review the changes?
>
>My commit is 
>https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commi
>t;h=3bac7b8c07b21eaa3a7b244f4d74efa7b4b5b41f
>
>Cheers,
>
>Hugo
>
>

Reply via email to