----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9158/#review15853 -----------------------------------------------------------
api/src/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java <https://reviews.apache.org/r/9158/#comment34144> Also you have put required=true, is the parameter mandatory? I don't think this should be mandatory otherwise back compat would break. server/src/com/cloud/vm/UserVmManagerImpl.java <https://reviews.apache.org/r/9158/#comment34141> if newTemplateId id passed there is no need to check old template id. server/src/com/cloud/vm/UserVmManagerImpl.java <https://reviews.apache.org/r/9158/#comment34143> template id in log message should be correctly chosen based on what is used - Koushik Das On Jan. 30, 2013, 11:32 a.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9158/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2013, 11:32 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Koushik Das. > > > Description > ------- > > CLOUDSTACK-667: VM's base image updation facility > disconnect the root disk >> destroy root disk >> create a new disk from new > template >> attach new disk as root disk to the vm > > > This addresses bug CLOUDSTACK-667. > > > Diffs > ----- > > api/src/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java d906c7f > server/src/com/cloud/vm/UserVmManagerImpl.java 5891056 > > Diff: https://reviews.apache.org/r/9158/diff/ > > > Testing > ------- > > Did the manual testing locally > > > Thanks, > > Harikrishna Patnala > >
