Thanks Chip. I agree that this should be judged by case. If the merge is individual enough, a [MERGE] notification should be good enough. Otherwise, the potential issue should be discussed ahead
> -----Original Message----- > From: Chip Childers [mailto:[email protected]] > Sent: Wednesday, January 30, 2013 10:45 AM > To: [email protected] > Subject: Re: [DISCUSS] topic branch merge, is there any time window? > > On Tue, Jan 29, 2013 at 5:36 PM, Frank Zhang <[email protected]> > wrote: > > I have a generic question regarding merging topic branch to master/javelin. > Is there any time window we should stop and wait for concerns/review on > the code? > > The topic branches have been passed 72 hours vote window and have > functional spec/bug number ready. > > Purely IMO, I think that if the discussion has already happened on the dev > list > about requirements and FS, the code has been looked at by others (or > people have had the opportunity to look at it), you have tested and feel > confident, then the MERGE request is really a notification to make sure folks > know you are going to do it. It will entirely depend on the nature (scope) of > the changes. An isolated feature can probably be merged very quickly with > little debate. > > I guess I'd summarize my thoughts as: committers should "do the right thing" > for the code and the community. That's not a particularly specific answer, > but that's what I feel. > > -chip
