> On Dec. 16, 2012, 12:22 p.m., Nitin Mehta wrote: > > Dont you have to take care of migration ? Do you think this upgraded script > > will be pushed to all existing 6.1 XS once they migrate to this version ? > > I am surprised why would XS run away from this convention of not storing > > vhd-util in only one of the version - any idea bcz this break compatibility > > since vhd-util is a widely used utility ? > > Do you think its ok to hard code the path in the file rather than passing > > it as an argument ?
When cloudstack does a connects to a Xenserver host, it checks if a tag is present that contains "vmops-version-" and the "<version>". If either tag is not found then the helper scripts are copied across to the host. In case of migration, the packageVersion will not match (with <version> in the tag) and cloudstack will copy the scripts again to the host. - Devdeep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8623/#review14552 ----------------------------------------------------------- On Dec. 16, 2012, 10:46 a.m., Devdeep Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8623/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2012, 10:46 a.m.) > > > Review request for cloudstack. > > > Description > ------- > > CS-16544: Create Snapshot (2nd time - reccuring) is failing on XenServer 6.1. > The issue is that while backing up a snapshot when cloudstack tries to update > the parent (of the backed up vhd), vhd-util isn't present at the desired > location and setParent function in vmopsSnapshot fails. This issue is > observed only on Xenserver 6.1. The reason for this is, when CloudStack > connects to a Xenserver and executes the SetupCommand, it copies vhd-util > tool to /opt/xensource/bin directory on the host. However, in vmopsSnapshot > python file 'VHD_UTIL' is initialized to /usr/sbin/. The issue is not > observed on 6.0.2 (and I guess previous versions) because vhd-util is present > in /usr/sbin/ directory by default (after a clean install). Whereas, in > Xenserver 6.1, vhd-util is present in '/usr/bin'. Fixed the issue by updating > VHD_UTIL to point to /opt/xensource/bin/vhd-util in vmopsSnapshot file. > > > This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-647. > > > Diffs > ----- > > scripts/vm/hypervisor/xenserver/vmopsSnapshot 80e21f8 > > Diff: https://reviews.apache.org/r/8623/diff/ > > > Testing > ------- > > Tested by taking multiple snapshots of the same volume. > > > Thanks, > > Devdeep Singh > >
