----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9179/#review15993 -----------------------------------------------------------
createGuestNetwork signature has changed due to IPV6 merge. Patch is not applying. Can you please rebase to new master and the new patch. Otherwise changes look good. - Murali Reddy On Jan. 31, 2013, 3:40 p.m., Likitha Shetty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9179/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2013, 3:40 p.m.) > > > Review request for cloudstack, Murali Reddy and Chiradeep Vittal. > > > Description > ------- > > Review request for Persistent networks > ====================================== > > a) A flag called 'Persistent' added to the network offerings will define if > the network created using the network offering is persistent or not. Default > value is false. > > b) After network creation, in the following 3 cases network will be > implemented (persistent is true) > 1. Creation of Guest network > 2. Moving VM to another user > 3. Associating IP Address to an account > > c) Network GC will not shutdown the network if it is persistent > > > This addresses bug CLOUDSTACK-706. > > > Diffs > ----- > > api/src/com/cloud/offering/NetworkOffering.java f2c4de5 > api/src/org/apache/cloudstack/api/ApiConstants.java d242830 > > api/src/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java > 9d3ceb8 > api/src/org/apache/cloudstack/api/response/NetworkOfferingResponse.java > 5c14791 > api/src/org/apache/cloudstack/api/response/NetworkResponse.java 64cc953 > server/src/com/cloud/api/ApiResponseHelper.java 641f25b > server/src/com/cloud/configuration/ConfigurationManager.java 19e74bf > server/src/com/cloud/configuration/ConfigurationManagerImpl.java df6642a > server/src/com/cloud/network/NetworkManagerImpl.java 0a4851f > server/src/com/cloud/network/NetworkServiceImpl.java 7530e94 > server/src/com/cloud/network/dao/NetworkDaoImpl.java 29e2f81 > server/src/com/cloud/network/dao/NetworkOpDaoImpl.java 298156e > server/src/com/cloud/offerings/NetworkOfferingVO.java efaca76 > server/src/com/cloud/server/ConfigurationServerImpl.java b0abd04 > server/src/com/cloud/vm/UserVmManagerImpl.java 3737450 > server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 3989ecf > server/test/com/cloud/vpc/MockNetworkManagerImpl.java a0f9d00 > server/test/com/cloud/vpc/dao/MockNetworkOfferingDaoImpl.java 496864b > setup/db/create-schema.sql ead98a5 > setup/db/db/schema-40to410.sql ed4946e > > Diff: https://reviews.apache.org/r/9179/diff/ > > > Testing > ------- > > Manual testing done > 1. Create network offering with persistent set to true for Isolated network - > creates an offering > 2. Create network offering with persistent set to true for Shared network - > fails > 3. Create guest network with persistent network offering - Network should get > implemented and should have a VLAN id > 4. Create guest network with a non persistent network offering - Network > should remain in allocated state > 5. Delete the last running VM of a persistent network - after a wait of > network.gc.interval the network should remain in implemented state > 6. Upgrade network offering of a non-persistent network to a persistent > network - network should get implemented > 7. Upgrade network offering of a persistent network to a non persistent > network - if there are no running VM's network should get shutdown during > network gc > 8. Move a VM from a user account to another user account that has no network > - a network created for the VM should be persistent if the available network > offering is persistent (same for associate ip address) > (repeat all of above for VPC network) > > > Thanks, > > Likitha Shetty > >
